Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: unmatched div tag in menu-item.template.ts #6848

Closed
wants to merge 3 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bug: removed the div tag
kamalrohra committed Oct 7, 2023
commit ecebe1c4134828b84da06fe698c8ba4234c5e4fa
Original file line number Diff line number Diff line change
@@ -31,32 +31,30 @@ export function menuItemTemplate<T extends FASTMenuItem>(
@mouseover="${(x, c) => x.handleMouseOver(c.event as MouseEvent)}"
@mouseout="${(x, c) => x.handleMouseOut(c.event as MouseEvent)}"
>
<div>
${when(
x => x.role === MenuItemRole.menuitemcheckbox,
html<FASTMenuItem>`
<div part="input-container" class="input-container">
<span part="checkbox" class="checkbox">
<slot name="checkbox-indicator">
${staticallyCompose(options.checkboxIndicator)}
</slot>
</span>
</div>
`
)}
${when(
x => x.role === MenuItemRole.menuitemradio,
html<FASTMenuItem>`
<div part="input-container" class="input-container">
<span part="radio" class="radio">
<slot name="radio-indicator">
${staticallyCompose(options.radioIndicator)}
</slot>
</span>
</div>
`
)}
</div>
${when(
x => x.role === MenuItemRole.menuitemcheckbox,
html<FASTMenuItem>`
<div part="input-container" class="input-container">
<span part="checkbox" class="checkbox">
<slot name="checkbox-indicator">
${staticallyCompose(options.checkboxIndicator)}
</slot>
</span>
</div>
`
)}
${when(
x => x.role === MenuItemRole.menuitemradio,
html<FASTMenuItem>`
<div part="input-container" class="input-container">
<span part="radio" class="radio">
<slot name="radio-indicator">
${staticallyCompose(options.radioIndicator)}
</slot>
</span>
</div>
`
)}
${startSlotTemplate(options)}
<span class="content" part="content">
<slot></slot>