fix: use local placeholder image in fast-ssr tests #6856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radium-v
requested review from
chrisdholt,
nicholasrice and
EisenbergEffect
as code owners
chrisdholt
approved these changes
Nov 2, 2023
chrisdholt
deleted the
users/jokreitl/use-local-placeholder-image-in-fast-ssr-tests
branch
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
* use local placeholder image in fast-ssr tests * Change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Some of the tests in
fast-ssruse placeholder images. This PR makes those images load locally instead of calling out to a placeholder service (which has rate limits).📑 Test Plan
All tests for
fast-ssrshould pass as expected.✅ Checklist
General
$ yarn change