fix: RtlScrollConverter test on high dpi systems in fast-web-utilities #6857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adjusts the scrollLeft check to consider the devicePixelRatio
radium-v
requested review from
chrisdholt,
nicholasrice and
EisenbergEffect
as code owners
KingOfTac
approved these changes
Nov 8, 2023
chrisdholt
approved these changes
Nov 8, 2023
5 tasks
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
#6857) * fix RtlScrollConverter test for high dpi systems - Adjusts the scrollLeft check to consider the devicePixelRatio * Change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Fixes an intermittently failing test that seems to be affected by the device pixel ratio.
👩💻 Reviewer Notes
This test returns
0.5on my Macbook Pro, since the test environment gets the same device pixel ratio as my screen (2).📑 Test Plan
The
RtlScrollConvertertest should pass in all environments.✅ Checklist
General
$ yarn change⏭ Next Steps
I encountered this bug while testing #6847, but it's present on the main branch as well. Perhaps there's a way to override the behavior that's causing the test runner to use the host's display properties?