Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

Fix duplicate bytes #25

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

avoltz
Copy link
Contributor

@avoltz avoltz commented Oct 7, 2020

Fix #24

The logic which checks if content exceeds the block max has a bug where the last byte is sent again.

In a simpler form the bug is just:
x = 'test'
x[0..2] is 'tes'
x[2..] is 'st'

I think this never caused an issue with max len buffers because the constant subtracts 1, so there's room in the request to send that extra byte.

I applied this fix and ran the test described in #24 and the blob contents match the text file.

I also added some tests for this area.

@elsesiy
Copy link
Contributor

elsesiy commented Oct 14, 2020

Good catch @avoltz! @logachev can we get this merged and a new release cut?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duplicate bytes are sent to blob when a buffer exceeds the append block size
3 participants