Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publish test result artifact #1885

Merged
merged 3 commits into from
Nov 13, 2023
Merged

publish test result artifact #1885

merged 3 commits into from
Nov 13, 2023

Conversation

harrieshin
Copy link
Contributor

@harrieshin harrieshin commented Sep 7, 2023 •
edited
Loading

Platforms Impacted

  • iOS
  • macOS

Description of changes

When the CI completes the test, save the xcode test results (which will mega bytes of content), zip it and store it in github artifact for 3 days.
image
image

Binary change

n/a

Verification

download artifact after CI and open in xcode

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@harrieshin harrieshin marked this pull request as ready for review November 13, 2023 17:04
@harrieshin harrieshin requested a review from a team as a code owner November 13, 2023 17:04
@harrieshin harrieshin changed the title [draft] publish test result artifact publish test result artifact Nov 13, 2023
mischreiber
mischreiber approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@mischreiber mischreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off assuming there's no issue with storage, since this'll run on each iteration of each PR.

@harrieshin
Copy link
Contributor Author

Signing off assuming there's no issue with storage, since this'll run on each iteration of each PR.

Yeah I am hoping it will be fine becuz the storage is valid for 3 days

@harrieshin harrieshin merged commit 0af75eb into microsoft:main Nov 13, 2023
6 checks passed
@mischreiber mischreiber mentioned this pull request Nov 17, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischreiber mischreiber mischreiber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harrieshin @mischreiber