Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to customize TableViewCell separator color #1923

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Oct 31, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

Added ability to customize TableViewCell's separator color. A new token separatorColor was added to TableViewCellTokenSet.

Binary change

Total increase: 7,704 bytes
Total decrease: 0 bytes

File Before After Delta
Total 30,796,008 bytes 30,803,712 bytes ⚠️ 7,704 bytes
Full breakdown
File Before After Delta
TableViewCell.o 805,384 bytes 809,800 bytes ⚠️ 4,416 bytes
TableViewCellTokenSet.o 108,280 bytes 109,984 bytes ⚠️ 1,704 bytes
__.SYMDEF 4,770,960 bytes 4,772,144 bytes ⚠️ 1,184 bytes
PopupMenuItemCell.o 174,072 bytes 174,208 bytes ⚠️ 136 bytes
PersonaCell.o 62,704 bytes 62,832 bytes ⚠️ 128 bytes
BooleanCell.o 89,904 bytes 90,032 bytes ⚠️ 128 bytes
ListActionItem.o 224,808 bytes 224,816 bytes ⚠️ 8 bytes

Verification

Visual Verification
Light Dark
image image

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@joannaquu joannaquu requested a review from a team as a code owner October 31, 2023 16:27
Copy link
Contributor

@laminesm laminesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest choosing a more drastic override color in the demo like pink so we can see the overridden separator easier since it's a very tiny control.

@alexanderboswell
Copy link
Contributor

alexanderboswell commented Oct 31, 2023

@harrieshin
Copy link
Contributor

I'd suggest choosing a more drastic override color in the demo like pink so we can see the overridden separator easier since it's a very tiny control.

not pink. otherwise accessibility vendors will flag our app as not color contrast accessible.

@joannaquu
Copy link
Contributor Author

we should also update here: https://github.com/microsoft/fluentui-apple/blob/main/ios/FluentUI/List/ListActionItem.swift

Will do in future pr

@joannaquu joannaquu merged commit f50c43a into microsoft:main Oct 31, 2023
6 checks passed
@joannaquu joannaquu deleted the joannaqu/separator-color branch October 31, 2023 22:00
@mischreiber mischreiber mentioned this pull request Nov 17, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants