Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to customize SideTabBar's background and separator color #1943

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Dec 12, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

Added ability to customize SideTabBar's background and separator color. Two new tokens, backgroundColor and separatorColor were added to SideTabBarTokenSet. Also fixed some comments/whitespace.

Binary change

Total increase: 52,136 bytes
Total decrease: -30,184 bytes

File Before After Delta
Total 30,900,632 bytes 30,922,584 bytes ⚠️ 21,952 bytes
Full breakdown
File Before After Delta
FluentTheme.o 154,904 bytes 197,472 bytes ⚠️ 42,568 bytes
SideTabBar.o 199,568 bytes 205,704 bytes ⚠️ 6,136 bytes
SideTabBarTokenSet.o 49,848 bytes 52,632 bytes ⚠️ 2,784 bytes
FocusRingView.o 814,384 bytes 815,032 bytes ⚠️ 648 bytes
__.SYMDEF 4,777,304 bytes 4,775,368 bytes 🎉 -1,936 bytes
FluentUIFramework.o 104,616 bytes 76,368 bytes 🎉 -28,248 bytes

Verification

Visual Verification
Light Dark
light dark

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@joannaquu joannaquu requested a review from a team as a code owner December 12, 2023 21:45
@joannaquu joannaquu merged commit f505a42 into microsoft:main Dec 13, 2023
6 checks passed
@joannaquu joannaquu deleted the joannaqu/side-tab-bar branch December 13, 2023 19:05
@mischreiber mischreiber mentioned this pull request Mar 6, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants