Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #1929 #1945

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Revert #1929 #1945

merged 2 commits into from
Dec 20, 2023

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Dec 15, 2023 •
edited by microsoft-github-policy-service bot
Loading

Platforms Impacted

  • iOS
  • macOS

Description of changes

#1929 seems to be causing some very weird behavior with the TableViewHeaderFooterView. Headers that should be headerPrimary are showing up as header and vice versa. And some headers are changing on scroll. Reverting this change until it can be investigated.

Verification

Visual Verification
Before After
primary before primary after
header before header after
scroll before scroll after

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@joannaquu
Revert "TableViewHeaderFooterView should not override any font or col…
82a2d17 
…or provided as part of the AttributedString (microsoft#1929)"

This reverts commit 559db71.
@joannaquu joannaquu requested a review from a team as a code owner December 15, 2023 00:34
laminesm
laminesm reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@laminesm laminesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we on a rush to cut a new minor version? Otherwise we should probably forward fix this.

@joannaquu
Copy link
Contributor Author

Are we on a rush to cut a new minor version? Otherwise we should probably forward fix this.

Following up offline

@joannaquu joannaquu enabled auto-merge (squash) December 19, 2023 19:01
@joannaquu joannaquu removed the request for review from owenconnolly December 20, 2023 01:56
@joannaquu joannaquu disabled auto-merge December 20, 2023 01:57
@joannaquu joannaquu merged commit 22f70c5 into microsoft:main Dec 20, 2023
6 checks passed
mischreiber pushed a commit to mischreiber/fluentui-apple that referenced this pull request Dec 20, 2023
@joannaquu @mischreiber
Revert "TableViewHeaderFooterView should not override any font or col…
0f4fbb6 
…or provided as part of the AttributedString (microsoft#1929)" (microsoft#1945)

This reverts commit 559db71.
mischreiber added a commit that referenced this pull request Dec 20, 2023
@mischreiber @joannaquu
Revert "TableViewHeaderFooterView should not override any font or col…
39eccf8 
…or provided as part of the AttributedString (#1929)" (#1945) (#1947)

This reverts commit 559db71.

Co-authored-by: Joanna Qu <[email protected]>
@joannaquu joannaquu deleted the joannaqu/revert-1929 branch February 6, 2024 21:12
@mischreiber mischreiber mentioned this pull request Mar 6, 2024
Merged
12 tasks
@nodes11 nodes11 mentioned this pull request May 31, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laminesm laminesm laminesm left review comments

@mischreiber mischreiber mischreiber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joannaquu @mischreiber @laminesm