Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all macOS targets to 12.0 #1946

Conversation

mischreiber
Copy link
Contributor

@mischreiber mischreiber commented Dec 18, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

Some of our macOS targets were providing their own deployment overrides in their xcscheme files, which has been triggering GitHub failure checks. This removes those overrides and brings us to 12.0 across the board.

Binary change

n/a

Verification

n/a

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested review from a team as code owners December 18, 2023 22:53
@anandrajeswaran
Copy link
Contributor

Not caused by this review so feel free to split to a separate change - I totally missed that the settings for the xctest target were added directly into the .pbxproj. Should be quick enough to move to an xcconfig to prevent the duplication and over specification?

@mischreiber mischreiber merged commit 2170a5b into microsoft:main Dec 19, 2023
6 checks passed
@mischreiber mischreiber deleted the user/mischreiber/fixMacDeploymentTargets branch December 19, 2023 17:02
@mischreiber mischreiber mentioned this pull request Mar 6, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants