-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS][macOS] Remove iOS Xcode Project #2082
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mischreiber
changed the title
Remove iOS Xcode Project
[DRAFT] Remove iOS Xcode Project
Aug 12, 2024
mischreiber
force-pushed
the
removeXcodeProjects
branch
3 times, most recently
from
August 13, 2024 17:40
bfa9dbe
to
e2deaf7
Compare
mischreiber
force-pushed
the
removeXcodeProjects
branch
from
August 28, 2024 22:49
e2deaf7
to
cf2c673
Compare
mischreiber
force-pushed
the
removeXcodeProjects
branch
from
September 12, 2024 17:35
1781732
to
ecac282
Compare
mischreiber
changed the title
[DRAFT] Remove iOS Xcode Project
[iOS][macOS] Remove iOS Xcode Project
Sep 17, 2024
joannaquu
approved these changes
Sep 17, 2024
anandrajeswaran
approved these changes
Sep 17, 2024
nodes11
approved these changes
Sep 17, 2024
Confirmed through testing in a few apps that this should represent a <10kB binary increase across the board. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Use SPM exclusively for consuming Fluent within our macOS and iOS demo apps.
A side-effect of this change is a major overhaul of how our library interacts with Xcode. In particular:
Both demo app projects (macOS and iOS) will now consume the FluentUI library directly via Swift Package Manager. This will facilitate upcoming refactors to make it easier to share code between iOS and macOS.
Binary change
The current system for measuring binary impact is no longer valid, since there will no longer be a discrete
libFluentUI.a
created as part of the build process. I'm currently exploring newer approaches to measure binary impact.Verification
Extensive sanity passes of both macOS and iOS test apps confirm no loss of functionality.
Tests included:
Avatar
)Visual Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow