Accordion: change parameter name

microsoft · Nov 13, 2023 · bea8d06 · bea8d06
1 parent c81efc3
commit bea8d06
Show file tree

Hide file tree

Showing 8 changed files with 21 additions and 11 deletions.
diff --git a/examples/Demo/Shared/Microsoft.FluentUI.AspNetCore.Components.xml b/examples/Demo/Shared/Microsoft.FluentUI.AspNetCore.Components.xml
@@ -38,11 +38,15 @@
         <member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentAccordionItem.Heading">
             <summary>
             Gets or sets the heading of the accordion item.
+            Use either this or the <see cref="P:Microsoft.FluentUI.AspNetCore.Components.FluentAccordionItem.HeadingTemplate"/> parameter."/>
+            If both are set, this parameter will be used.
             </summary>
         </member>
-        <member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentAccordionItem.HeadingContent">
+        <member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentAccordionItem.HeadingTemplate">
             <summary>
             Gets or sets the heading content of the accordion item.
+            Use either this or the <see cref="P:Microsoft.FluentUI.AspNetCore.Components.FluentAccordionItem.Heading"/> parameter."/>
+            If both are set, this parameter will not be used.
             </summary>
         </member>
         <member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentAccordionItem.Expanded">

diff --git a/examples/Demo/Shared/Pages/Accordion/Examples/AccordionDefault.razor b/examples/Demo/Shared/Pages/Accordion/Examples/AccordionDefault.razor
@@ -14,9 +14,9 @@
         Panel three content
     </FluentAccordionItem>
     <FluentAccordionItem Expanded="true">
-        <HeadingContent>
+        <HeadingTemplate>
             Panel <span style="color:red">Four</span>
-        </HeadingContent>
+        </HeadingTemplate>
         <ChildContent>
             Panel four content
         </ChildContent>

diff --git a/src/Core/Components/Accordion/FluentAccordionItem.razor b/src/Core/Components/Accordion/FluentAccordionItem.razor
@@ -14,7 +14,7 @@
     else
     {
         <div slot="heading">
-            @HeadingContent
+            @HeadingTemplate
         </div>
     }
     @ChildContent

diff --git a/src/Core/Components/Accordion/FluentAccordionItem.razor.cs b/src/Core/Components/Accordion/FluentAccordionItem.razor.cs
@@ -12,15 +12,19 @@ public partial class FluentAccordionItem : FluentComponentBase, IDisposable
 
     /// <summary>
     /// Gets or sets the heading of the accordion item.
+    /// Use either this or the <see cref="HeadingTemplate"/> parameter."/>
+    /// If both are set, this parameter will be used.
     /// </summary>
     [Parameter]
     public string? Heading { get; set; }
 
     /// <summary>
     /// Gets or sets the heading content of the accordion item.
+    /// Use either this or the <see cref="Heading"/> parameter."/>
+    /// If both are set, this parameter will not be used.
     /// </summary>
     [Parameter]
-    public RenderFragment? HeadingContent { get; set; }
+    public RenderFragment? HeadingTemplate { get; set; }
 
     /// <summary>
     /// Expands or collapses the item.

diff --git a/...ntAndHeading_IsProvidedBoth.verified.html → ...teAndHeading_IsProvidedBoth.verified.html b/...ntAndHeading_IsProvidedBoth.verified.html → ...teAndHeading_IsProvidedBoth.verified.html
diff --git a/...m_WithHeadingContent_IsNull.verified.html → ..._WithHeadingTemplate_IsNull.verified.html b/...m_WithHeadingContent_IsNull.verified.html → ..._WithHeadingTemplate_IsNull.verified.html
@@ -1,3 +1,4 @@
+
 <fluent-accordion-item id="xxx" blazor:elementreference="xxx">
   <div slot="heading"></div>
 </fluent-accordion-item>
diff --git a/...thHeadingContent_IsProvided.verified.html → ...hHeadingTemplate_IsProvided.verified.html b/...thHeadingContent_IsProvided.verified.html → ...hHeadingTemplate_IsProvided.verified.html
@@ -1,3 +1,4 @@
+
 <fluent-accordion-item id="xxx" blazor:elementreference="xxx">
   <div slot="heading">custom heading content</div>
 </fluent-accordion-item>
diff --git a/tests/Core/Accordion/FluentAccordionItemTests.cs b/tests/Core/Accordion/FluentAccordionItemTests.cs
@@ -42,12 +42,12 @@ public void FluentAccordionItem_WithCustomHeaderValue()
     }
 
     [Fact]
-    public void FluentAccordionItem_WithHeadingContentAndHeading_IsProvidedBoth()
+    public void FluentAccordionItem_WithHeadingTemplateAndHeading_IsProvidedBoth()
     {
         // Arrange & Act
         var cut = TestContext.RenderComponent<FluentAccordionItem>(parameters =>
         {
-            parameters.Add(p => p.HeadingContent, context =>
+            parameters.Add(p => p.HeadingTemplate, context =>
             {
                 context.AddContent(0, "custom heading content");
             });
@@ -145,25 +145,25 @@ public void FluentAccordionItem_WhenAdditionalStyle_IsProvided()
     }
 
     [Fact]
-    public void FluentAccordionItem_WithHeadingContent_IsNull()
+    public void FluentAccordionItem_WithHeadingTemplate_IsNull()
     {
         // Arrange & Act
         var cut = TestContext.RenderComponent<FluentAccordionItem>(parameters =>
         {
-            parameters.Add(p => p.HeadingContent, context => { });
+            parameters.Add(p => p.HeadingTemplate, context => { });
         });
 
         // Assert
         cut.Verify();
     }
 
     [Fact]
-    public void FluentAccordionItem_WithHeadingContent_IsProvided()
+    public void FluentAccordionItem_WithHeadingTemplate_IsProvided()
     {
         // Arrange & Act
         var cut = TestContext.RenderComponent<FluentAccordionItem>(parameters =>
         {
-            parameters.Add(p => p.HeadingContent, context =>
+            parameters.Add(p => p.HeadingTemplate, context =>
             {
                 context.AddContent(0, "custom heading content");
             });