Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove FluentDataGridRow z-index property #835

Closed
wants to merge 2 commits into from

Conversation

LuohuaRain
Copy link
Contributor

@LuohuaRain LuohuaRain commented Oct 9, 2023

Pull Request

📖 Description

When the z-index of FluentDataGridRow is set to 3, it conflicts with the styles of some components, such as FluentSelect.
image

Therefore, the z-index property is removed from FluentDataGridRow.
image

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new compontent
  • I have modified an existing component
  • I have validate Unit Tests for an existing component

⏭ Next Steps

@vnbaaij
Copy link
Collaborator

vnbaaij commented Oct 9, 2023

The z-index had been given this value for a reason. Please see #744.
A solution for the list to appear above the grid was given in #771. Please confirm that this solution works for you as well. If not, then we can see how we can change this but this PR will not be merged in its current form.

@LuohuaRain
Copy link
Contributor Author

Thank you for pointing me to issues #744 and #771. I have reviewed the suggested solution in #771 and confirmed that it works for my case as well. Given that the current z-index value has its reasons, I agree that this PR is not needed in its current form. Thanks for your guidance.

@LuohuaRain LuohuaRain closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants