Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Components Doc] use of new components tels FluentLayout, FluentHeader.. #888

Merged
merged 14 commits into from
Oct 27, 2023

Conversation

tossnet
Copy link
Contributor

@tossnet tossnet commented Oct 24, 2023

Pull Request

📖 Description

The demo site didn't use the new components, so I replaced the header elements with FluentHeader, FluentBody etc. I also added some CSS styling so that the menu and content had verticals scrollbars to improve the UX.

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new compontent
  • I have modified an existing component
  • I have validate Unit Tests for an existing component

⏭ Next Steps

examples/Demo/Shared/Shared/DemoNavMenu.razor.css Outdated Show resolved Hide resolved
examples/Demo/Shared/Shared/DemoNavMenu.razor.cs Outdated Show resolved Hide resolved
examples/Demo/Shared/Shared/DemoNavMenu.razor.css Outdated Show resolved Hide resolved
@dvoituron
Copy link
Collaborator

I'm having a problem with the latest modifications. The right panel is over the text :-(

image

@tossnet
Copy link
Contributor Author

tossnet commented Oct 26, 2023

😱

@vnbaaij vnbaaij enabled auto-merge (squash) October 27, 2023 15:15
@vnbaaij vnbaaij disabled auto-merge October 27, 2023 15:16
@vnbaaij vnbaaij merged commit 6a46caa into microsoft:dev Oct 27, 2023
3 checks passed
vnbaaij added a commit that referenced this pull request Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants