-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance FluentAccordionItem with Flexible HeadingContent Parameter #952
Conversation
Thank you for this useful improvement. |
Of course, I'll give a try. 😊 |
Hi, Thank you🚀 |
I'm looking at the tests now. So far, looking good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, we are taking the the PR as-is and change the parameter name ourselves. Thanks!!
Sorry, due to the time difference, I went out for dinner, and it took some time. Apologies.😭 |
No worries!! Hope you had a nice dinner. Thanks for making the initial changes. Getting it aligned to our naming is only a small change. |
Pull Request
📖 Description
I've updated the
FluentAccordionItem
component to enhance its flexibility and usability. Previously, attempting to control the heading slot resulted in a RZ2012 error. To address this issue, I've made the following changes:EditorRequiredAttribute
to avoid the RZ2012 error.RenderFragment?
parameter,HeadingContent
, providing an alternative way to specify the heading content. This addition allows users to define custom heading content more flexibly.🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps