review feedback

microsoft · Dec 13, 2024 · 0386842 · 0386842
1 parent 2d8c8c8
commit 0386842
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 13 deletions.
diff --git a/packages/react-components/eslint-plugin-react-components/README.md b/packages/react-components/eslint-plugin-react-components/README.md
@@ -57,10 +57,6 @@ module.exports = {
 
 This rule ensures the use of Fluent UI v9 counterparts for Fluent UI v8 components.
 
-#### Options
-
-- `unstable` (boolean): Whether to enforce Fluent UI v9 preview component migrations.
-
 #### Examples
 
 **✅ Do**

diff --git a/...onents/eslint-plugin-react-components/etc/eslint-plugin-react-components.api.md b/...onents/eslint-plugin-react-components/etc/eslint-plugin-react-components.api.md
@@ -22,9 +22,7 @@ export const plugin: {
         };
     };
     rules: {
-        "prefer-fluentui-v9": RuleModule<"replaceFluent8With9" | "replaceIconWithJsx" | "replaceStackWithFlex" | "replaceFocusZoneWithTabster", {
-        preview?: boolean | undefined;
-        }[], unknown, RuleListener>;
+        "prefer-fluentui-v9": RuleModule<"replaceFluent8With9" | "replaceIconWithJsx" | "replaceStackWithFlex" | "replaceFocusZoneWithTabster", {}[], unknown, RuleListener>;
     };
 };
 

diff --git a/packages/react-components/eslint-plugin-react-components/src/rules/prefer-fluentui-v9.ts b/packages/react-components/eslint-plugin-react-components/src/rules/prefer-fluentui-v9.ts
@@ -13,12 +13,7 @@ export const rule = createRule<Options, MessageIds>({
     docs: {
       description: 'This rule ensures the use of Fluent UI v9 counterparts for Fluent UI v8 components.',
     },
-    schema: [
-      {
-        type: 'object',
-        properties: {},
-      },
-    ],
+    schema: [],
     messages: {
       replaceFluent8With9: `Avoid importing {{ fluent8 }} from '@fluentui/react', as this package has started migration to Fluent UI 9. Import {{ fluent9 }} from '{{ package }}' instead.`,
       replaceIconWithJsx: `Avoid using Icon from '@fluentui/react', as this package has already migrated to Fluent UI 9. Use a JSX SVG icon from '@fluentui/react-icons' instead.`,