streamline active option handling

microsoft · Dec 20, 2024 · 1a1bb2e · 1a1bb2e
1 parent b08f465
commit 1a1bb2e
Showing 1 changed file with 11 additions and 20 deletions.
diff --git a/packages/web-components/src/dropdown/dropdown.ts b/packages/web-components/src/dropdown/dropdown.ts
@@ -59,7 +59,17 @@ export class BaseDropdown extends FASTElement {
    * @internal
    */
   public activeIndexChanged(prev: number | undefined, next: number | undefined): void {
-    this.setActiveOption();
+    if (typeof next === 'number') {
+      const optionIndex = this.matches(':has(:focus-visible)') ? next : -1;
+
+      this.enabledOptions.forEach((option, index) => {
+        option.active = index === optionIndex;
+      });
+
+      if (this.open) {
+        this.enabledOptions[optionIndex]?.scrollIntoView({ block: 'nearest' });
+      }
+    }
   }
 
   /**
@@ -694,8 +704,6 @@ export class BaseDropdown extends FASTElement {
 
     this.activeIndex = indexInBounds;
 
-    this.setActiveOption(true);
-
     return true;
   }
 
@@ -714,23 +722,6 @@ export class BaseDropdown extends FASTElement {
     return !isOption(e.target as HTMLElement);
   }
 
-  /**
-   * Sets the `active` state on the currently focused option.
-   *
-   * @internal
-   */
-  public setActiveOption(force?: boolean): void {
-    const optionIndex = this.matches(':has(:focus-visible)') || force ? this.activeIndex : -1;
-
-    this.enabledOptions.forEach((option, index) => {
-      option.active = index === optionIndex;
-    });
-
-    if (this.open) {
-      this.enabledOptions[optionIndex]?.scrollIntoView({ block: 'nearest' });
-    }
-  }
-
   /**
    * Selects an option by index.
    *