Skip to content

Commit

Permalink
chore: enable @nx/workspace-no-missing-jsx-pragma in whole monorepo (
Browse files Browse the repository at this point in the history
  • Loading branch information
Hotell authored Oct 16, 2024
1 parent f45bb48 commit a5791a5
Show file tree
Hide file tree
Showing 17 changed files with 66 additions and 25 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "feat: enable @nx/workspace-no-missing-jsx-pragma rule for react v9 projects",
"packageName": "@fluentui/eslint-plugin",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "style: resolve exposed jsx pragma lint issues within monorepo",
"packageName": "@fluentui/react-aria",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "style: resolve exposed jsx pragma lint issues within monorepo",
"packageName": "@fluentui/react-carousel",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "style: resolve exposed jsx pragma lint issues within monorepo",
"packageName": "@fluentui/react-migration-v0-v9",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "style: resolve exposed jsx pragma lint issues within monorepo",
"packageName": "@fluentui/react-nav-preview",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "style: resolve exposed jsx pragma lint issues within monorepo",
"packageName": "@fluentui/react-tag-picker",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "style: resolve exposed jsx pragma lint issues within monorepo",
"packageName": "@fluentui/react-teaching-popover",
"email": "[email protected]",
"dependentChangeType": "patch"
}
1 change: 1 addition & 0 deletions packages/eslint-plugin/src/internal.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ const __internal = {
rules: {
'@nx/workspace-consistent-callback-type': 'error',
'@nx/workspace-no-restricted-globals': restrictedGlobals.react,
'@nx/workspace-no-missing-jsx-pragma': ['error', { runtime: 'automatic' }],
},
}
: null,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
/** @jsxRuntime automatic */
/** @jsxImportSource @fluentui/react-jsx-runtime */

import * as React from 'react';
import { AnnounceProvider } from '@fluentui/react-shared-contexts';

import type { AriaLiveAnnouncerContextValues, AriaLiveAnnouncerState } from './AriaLiveAnnouncer.types';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
/** @jsxRuntime automatic */
/** @jsxImportSource @fluentui/react-jsx-runtime */

import { assertSlots } from '@fluentui/react-utilities';
import type { CarouselAutoplayButtonState, CarouselAutoplayButtonSlots } from './CarouselAutoplayButton.types';
import { renderToggleButton_unstable } from '@fluentui/react-button';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
/** @jsxRuntime automatic */
/** @jsxImportSource @fluentui/react-jsx-runtime */

import { assertSlots } from '@fluentui/react-utilities';
import type { CarouselButtonState, CarouselButtonSlots } from './CarouselButton.types';
import { renderButton_unstable } from '@fluentui/react-button';
Expand Down
11 changes: 10 additions & 1 deletion packages/react-components/react-jsx-runtime/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,13 @@
{
"extends": ["plugin:@fluentui/eslint-plugin/react"],
"root": true
"root": true,
"overrides": [
{
"files": ["**/*.{test,spec}.tsx"],
"excludedFiles": ["jsx-runtime.test.tsx"],
"rules": {
"@nx/workspace-no-missing-jsx-pragma": ["error", { "runtime": "classic" }]
}
}
]
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
/** @jsxRuntime classic */
/** @jsx createElement */
/** @jsxRuntime automatic */
/** @jsxImportSource @fluentui/react-jsx-runtime */

import { createElement } from '@fluentui/react-jsx-runtime';
import * as React from 'react';
import { mergeClasses } from '@fluentui/react-components';
import {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
/** @jsxRuntime automatic */
/** @jsxImportSource @fluentui/react-jsx-runtime */

import * as React from 'react';
import { NavCategoryContextValues, NavCategoryProvider } from '../NavCategoryContext';

import type { NavCategoryState } from './NavCategory.types';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
/** @jsxRuntime classic */
/** @jsx createElement */
/** @jsxRuntime automatic */
/** @jsxImportSource @fluentui/react-jsx-runtime */

import { createElement } from '@fluentui/react-jsx-runtime';
import { assertSlots } from '@fluentui/react-utilities';
import type { NavCategoryItemState, NavCategoryItemSlots, NavCategoryItemContextValues } from './NavCategoryItem.types';
import { NavCategoryItemProvider } from '../NavCategoryItemContext';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
/** @jsxRuntime automatic */
/** @jsxImportSource @fluentui/react-jsx-runtime */

import type { TagPickerOptionGroupState } from './TagPickerOptionGroup.types';
import { renderOptionGroup_unstable } from '@fluentui/react-combobox';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
/** @jsxRuntime classic */
/** @jsx createElement */

import type { TeachingPopoverSurfaceSlots, TeachingPopoverSurfaceState } from './TeachingPopoverSurface.types';
import { assertSlots } from '@fluentui/react-utilities';
import { renderPopoverSurface_unstable } from '@fluentui/react-popover';
Expand Down

0 comments on commit a5791a5

Please sign in to comment.