-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump swc core to mitigate transpilation memory leaks #29253
Conversation
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 68 | 10 | Possible regression |
InfoButton | mount | 8 | 11 | 5000 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 620 | 641 | 5000 | |
Button | mount | 323 | 318 | 5000 | |
Field | mount | 1106 | 1136 | 5000 | |
FluentProvider | mount | 733 | 713 | 5000 | |
FluentProviderWithTheme | mount | 79 | 82 | 10 | |
FluentProviderWithTheme | virtual-rerender | 63 | 59 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 68 | 10 | Possible regression |
InfoButton | mount | 8 | 11 | 5000 | Possible regression |
MakeStyles | mount | 859 | 848 | 50000 | |
Persona | mount | 1770 | 1709 | 5000 | |
SpinButton | mount | 1390 | 1384 | 5000 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a13ff2b:
|
🕵 fluentuiv8 No visual regressions between this PR and main |
Perf Analysis (
|
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
TreeWith60ListItems.default | 94 | 81 | 1.16:1 |
AttachmentMinimalPerf.default | 86 | 77 | 1.12:1 |
FlexMinimalPerf.default | 160 | 144 | 1.11:1 |
AlertMinimalPerf.default | 158 | 145 | 1.09:1 |
SkeletonMinimalPerf.default | 197 | 182 | 1.08:1 |
LayoutMinimalPerf.default | 206 | 193 | 1.07:1 |
ListNestedPerf.default | 321 | 301 | 1.07:1 |
CardMinimalPerf.default | 314 | 296 | 1.06:1 |
HeaderSlotsPerf.default | 470 | 445 | 1.06:1 |
PortalMinimalPerf.default | 84 | 79 | 1.06:1 |
StatusMinimalPerf.default | 394 | 373 | 1.06:1 |
TreeMinimalPerf.default | 475 | 448 | 1.06:1 |
IconMinimalPerf.default | 387 | 369 | 1.05:1 |
BoxMinimalPerf.default | 198 | 191 | 1.04:1 |
ButtonOverridesMissPerf.default | 681 | 653 | 1.04:1 |
TableMinimalPerf.default | 230 | 222 | 1.04:1 |
AccordionMinimalPerf.default | 80 | 78 | 1.03:1 |
AttachmentSlotsPerf.default | 642 | 624 | 1.03:1 |
DropdownManyItemsPerf.default | 391 | 380 | 1.03:1 |
InputMinimalPerf.default | 537 | 519 | 1.03:1 |
ProviderMinimalPerf.default | 200 | 194 | 1.03:1 |
ChatWithPopoverPerf.default | 190 | 187 | 1.02:1 |
EmbedMinimalPerf.default | 1890 | 1860 | 1.02:1 |
GridMinimalPerf.default | 187 | 184 | 1.02:1 |
RadioGroupMinimalPerf.default | 251 | 246 | 1.02:1 |
RefMinimalPerf.default | 108 | 106 | 1.02:1 |
SegmentMinimalPerf.default | 190 | 187 | 1.02:1 |
ButtonSlotsPerf.default | 313 | 311 | 1.01:1 |
ChatMinimalPerf.default | 430 | 427 | 1.01:1 |
DropdownMinimalPerf.default | 1432 | 1416 | 1.01:1 |
RosterPerf.default | 1538 | 1520 | 1.01:1 |
SplitButtonMinimalPerf.default | 2243 | 2220 | 1.01:1 |
ToolbarMinimalPerf.default | 523 | 517 | 1.01:1 |
CarouselMinimalPerf.default | 265 | 266 | 1:1 |
ChatDuplicateMessagesPerf.default | 154 | 154 | 1:1 |
DatepickerMinimalPerf.default | 3483 | 3480 | 1:1 |
DividerMinimalPerf.default | 201 | 202 | 1:1 |
ItemLayoutMinimalPerf.default | 704 | 706 | 1:1 |
LabelMinimalPerf.default | 210 | 211 | 1:1 |
MenuButtonMinimalPerf.default | 948 | 949 | 1:1 |
PopupMinimalPerf.default | 341 | 340 | 1:1 |
TableManyItemsPerf.default | 1099 | 1099 | 1:1 |
CustomToolbarPrototype.default | 1462 | 1467 | 1:1 |
ListMinimalPerf.default | 302 | 305 | 0.99:1 |
MenuMinimalPerf.default | 493 | 498 | 0.99:1 |
AnimationMinimalPerf.default | 279 | 285 | 0.98:1 |
ButtonMinimalPerf.default | 85 | 87 | 0.98:1 |
DialogMinimalPerf.default | 429 | 439 | 0.98:1 |
FormMinimalPerf.default | 211 | 215 | 0.98:1 |
HeaderMinimalPerf.default | 202 | 206 | 0.98:1 |
ImageMinimalPerf.default | 230 | 234 | 0.98:1 |
ListWith60ListItems.default | 346 | 352 | 0.98:1 |
ProviderMergeThemesPerf.default | 632 | 643 | 0.98:1 |
SliderMinimalPerf.default | 740 | 752 | 0.98:1 |
CheckboxMinimalPerf.default | 1110 | 1140 | 0.97:1 |
ListCommonPerf.default | 375 | 386 | 0.97:1 |
ReactionMinimalPerf.default | 207 | 213 | 0.97:1 |
TooltipMinimalPerf.default | 1262 | 1303 | 0.97:1 |
LoaderMinimalPerf.default | 190 | 197 | 0.96:1 |
AvatarMinimalPerf.default | 104 | 110 | 0.95:1 |
TextAreaMinimalPerf.default | 274 | 287 | 0.95:1 |
TextMinimalPerf.default | 188 | 200 | 0.94:1 |
VideoMinimalPerf.default | 425 | 455 | 0.93:1 |
🕵 FluentUIV0 No visual regressions between this PR and main |
📊 Bundle size reportUnchanged fixtures
|
🕵 fluentuiv9 No visual regressions between this PR and main |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 629 | 629 | 5000 | |
Breadcrumb | mount | 1671 | 1659 | 1000 | |
Checkbox | mount | 1672 | 1686 | 5000 | |
CheckboxBase | mount | 1485 | 1466 | 5000 | |
ChoiceGroup | mount | 2969 | 2922 | 5000 | |
ComboBox | mount | 643 | 640 | 1000 | |
CommandBar | mount | 6185 | 6106 | 1000 | |
ContextualMenu | mount | 13477 | 13498 | 1000 | |
DefaultButton | mount | 756 | 765 | 5000 | |
DetailsRow | mount | 2152 | 2145 | 5000 | |
DetailsRowFast | mount | 2197 | 2135 | 5000 | |
DetailsRowNoStyles | mount | 1938 | 1989 | 5000 | |
Dialog | mount | 2610 | 2641 | 1000 | |
DocumentCardTitle | mount | 220 | 233 | 1000 | |
Dropdown | mount | 1934 | 1972 | 5000 | |
FocusTrapZone | mount | 1141 | 1152 | 5000 | |
FocusZone | mount | 1059 | 1059 | 5000 | |
GroupedList | mount | 41232 | 41390 | 2 | |
GroupedList | virtual-rerender | 19967 | 19781 | 2 | |
GroupedList | virtual-rerender-with-unmount | 51127 | 50382 | 2 | |
GroupedListV2 | mount | 222 | 223 | 2 | |
GroupedListV2 | virtual-rerender | 205 | 207 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 218 | 215 | 2 | |
IconButton | mount | 1053 | 1085 | 5000 | |
Label | mount | 330 | 336 | 5000 | |
Layer | mount | 2660 | 2720 | 5000 | |
Link | mount | 385 | 418 | 5000 | |
MenuButton | mount | 918 | 915 | 5000 | |
MessageBar | mount | 22562 | 21316 | 5000 | |
Nav | mount | 1888 | 1912 | 1000 | |
OverflowSet | mount | 765 | 774 | 5000 | |
Panel | mount | 1780 | 1763 | 1000 | |
Persona | mount | 725 | 732 | 1000 | |
Pivot | mount | 836 | 836 | 1000 | |
PrimaryButton | mount | 835 | 854 | 5000 | |
Rating | mount | 4589 | 4619 | 5000 | |
SearchBox | mount | 902 | 916 | 5000 | |
Shimmer | mount | 1901 | 1845 | 5000 | |
Slider | mount | 1304 | 1313 | 5000 | |
SpinButton | mount | 2818 | 2890 | 5000 | |
Spinner | mount | 389 | 386 | 5000 | |
SplitButton | mount | 1828 | 1804 | 5000 | |
Stack | mount | 397 | 403 | 5000 | |
StackWithIntrinsicChildren | mount | 852 | 853 | 5000 | |
StackWithTextChildren | mount | 2581 | 2570 | 5000 | |
SwatchColorPicker | mount | 5985 | 6053 | 5000 | |
TagPicker | mount | 1415 | 1437 | 5000 | |
Text | mount | 356 | 369 | 5000 | |
TextField | mount | 946 | 929 | 5000 | |
ThemeProvider | mount | 832 | 823 | 5000 | |
ThemeProvider | virtual-rerender | 576 | 575 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1256 | 1249 | 5000 | |
Toggle | mount | 603 | 609 | 5000 | |
buttonNative | mount | 200 | 186 | 5000 |
currently we are blocked by ts-node TypeStrong/ts-node#2062 (test-ssr) or any tooling we use ts-node/register for will explode. update: unblocked by using nx apis. |
Asset size changesUnable to find bundle size details for Baseline commit: 5b6536c Possible causes
Recommendations
|
…ll v9 family of packages
9b472ca
to
a13ff2b
Compare
* master: fix(react-dialog): use makeResetStyles for base dialog components styles (microsoft#29280) chore(react-tags-preview): update props descriptions (microsoft#29287) chore: bump swc core to mitigate transpilation memory leaks (microsoft#29253) feat: adds customizeSelector to createCustomFocusIndicatorStyle method (microsoft#29209) applying package updates Updated TooltipBestPractices to include accessibility best practices (microsoft#29284) fix: BreadcrumbItem should use makeResetStyles for base styles (microsoft#29278)
Previous Behavior
New Behavior
Related Issue(s)