Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Enable 1ES PT to be compliant for all production pipelines. #29702

Merged
merged 6 commits into from
Oct 31, 2023
Merged

ci: Enable 1ES PT to be compliant for all production pipelines. #29702

merged 6 commits into from
Oct 31, 2023

Conversation

dannyvv
Copy link
Member

@dannyvv dannyvv commented Oct 30, 2023 •
edited by Hotell
Loading

New Behavior

Enable 1ES PT to be compliant for all production pipelines.

    This PR starts to split azure-pipelines.yml into azure-pipelines-pr.yml and
    azure-pipelines-ci.yml so that PR and CI don't share the exact same
    yaml to avoid compliance steps during PR.

    Once merged I'll move over the pipelines to their new yaml files respectively
    and submit another PR to remove azure-piplines.yml.

Fixes Partially #29580

@dannyvv dannyvv requested a review from a team as a code owner October 30, 2023 23:15
@dannyvv dannyvv enabled auto-merge (squash) October 30, 2023 23:17
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 30, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 630 623 5000
Button mount 311 314 5000
Field mount 1095 1112 5000
FluentProvider mount 694 709 5000
FluentProviderWithTheme mount 76 77 10
FluentProviderWithTheme virtual-rerender 65 59 10
FluentProviderWithTheme virtual-rerender-with-unmount 72 75 10
MakeStyles mount 876 859 50000
Persona mount 1741 1723 5000
SpinButton mount 1401 1410 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 30, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c0a2cd6:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 30, 2023 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 30, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
LoaderMinimalPerf.default 196 177 1.11:1
PortalMinimalPerf.default 92 83 1.11:1
ChatWithPopoverPerf.default 202 187 1.08:1
DividerMinimalPerf.default 214 198 1.08:1
TextMinimalPerf.default 197 184 1.07:1
VideoMinimalPerf.default 462 430 1.07:1
BoxMinimalPerf.default 198 186 1.06:1
ReactionMinimalPerf.default 214 202 1.06:1
TreeMinimalPerf.default 486 458 1.06:1
FormMinimalPerf.default 230 219 1.05:1
IconMinimalPerf.default 411 393 1.05:1
CarouselMinimalPerf.default 263 254 1.04:1
CheckboxMinimalPerf.default 1148 1107 1.04:1
ImageMinimalPerf.default 228 220 1.04:1
LabelMinimalPerf.default 221 213 1.04:1
MenuMinimalPerf.default 497 476 1.04:1
RadioGroupMinimalPerf.default 258 248 1.04:1
SkeletonMinimalPerf.default 202 194 1.04:1
TooltipMinimalPerf.default 1332 1286 1.04:1
AttachmentMinimalPerf.default 77 75 1.03:1
AttachmentSlotsPerf.default 660 638 1.03:1
HeaderSlotsPerf.default 474 459 1.03:1
InputMinimalPerf.default 542 524 1.03:1
TextAreaMinimalPerf.default 289 280 1.03:1
AnimationMinimalPerf.default 301 295 1.02:1
ChatMinimalPerf.default 432 424 1.02:1
DatepickerMinimalPerf.default 3650 3575 1.02:1
DropdownMinimalPerf.default 1428 1406 1.02:1
LayoutMinimalPerf.default 202 198 1.02:1
ListWith60ListItems.default 367 359 1.02:1
SliderMinimalPerf.default 760 748 1.02:1
ToolbarMinimalPerf.default 529 520 1.02:1
AccordionMinimalPerf.default 83 82 1.01:1
EmbedMinimalPerf.default 1871 1848 1.01:1
FlexMinimalPerf.default 152 150 1.01:1
PopupMinimalPerf.default 350 348 1.01:1
RefMinimalPerf.default 111 110 1.01:1
SegmentMinimalPerf.default 196 195 1.01:1
HeaderMinimalPerf.default 205 204 1:1
ListNestedPerf.default 321 320 1:1
MenuButtonMinimalPerf.default 949 952 1:1
SplitButtonMinimalPerf.default 2231 2235 1:1
TableManyItemsPerf.default 1104 1109 1:1
AlertMinimalPerf.default 153 154 0.99:1
ButtonOverridesMissPerf.default 639 644 0.99:1
ChatDuplicateMessagesPerf.default 147 149 0.99:1
DialogMinimalPerf.default 435 438 0.99:1
ListMinimalPerf.default 303 306 0.99:1
ProviderMergeThemesPerf.default 640 645 0.99:1
ProviderMinimalPerf.default 198 199 0.99:1
TableMinimalPerf.default 230 232 0.99:1
ButtonMinimalPerf.default 85 87 0.98:1
ButtonSlotsPerf.default 310 317 0.98:1
DropdownManyItemsPerf.default 388 395 0.98:1
GridMinimalPerf.default 190 193 0.98:1
ItemLayoutMinimalPerf.default 690 707 0.98:1
CustomToolbarPrototype.default 1442 1465 0.98:1
TreeWith60ListItems.default 79 81 0.98:1
CardMinimalPerf.default 298 306 0.97:1
RosterPerf.default 1546 1591 0.97:1
StatusMinimalPerf.default 377 389 0.97:1
AvatarMinimalPerf.default 101 107 0.94:1
ListCommonPerf.default 370 392 0.94:1

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 30, 2023 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@size-auditor
Copy link

size-auditor bot commented Oct 30, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: cc35c6608ad5d55c4f0312e688eb4a87aa487937 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 30, 2023 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 510 B
330 B
global-context
createContextSelector		 537 B
342 B
priority-overflow
createOverflowManager		 4.341 kB
1.81 kB
react-accordion
Accordion (including children components)		 92.983 kB
28.418 kB
react-alert
Alert		 84.293 kB
23.456 kB
react-avatar
Avatar		 50.534 kB
15.923 kB
react-avatar
AvatarGroup		 20.064 kB
7.894 kB
react-avatar
AvatarGroupItem		 65.19 kB
20.259 kB
react-badge
Badge		 27.264 kB
8.808 kB
react-badge
CounterBadge		 28.165 kB
9.101 kB
react-badge
PresenceBadge		 25.67 kB
9.313 kB
react-button
Button		 40.074 kB
11.292 kB
react-button
CompoundButton		 47.43 kB
12.787 kB
react-button
MenuButton		 44.848 kB
12.668 kB
react-button
SplitButton		 52.862 kB
14.254 kB
react-button
ToggleButton		 57.122 kB
13.194 kB
react-calendar-compat
Calendar Compat		 141.324 kB
36.821 kB
react-card
Card - All		 92.955 kB
26.977 kB
react-card
Card		 87.781 kB
25.462 kB
react-card
CardFooter		 13.423 kB
5.481 kB
react-card
CardHeader		 15.666 kB
6.235 kB
react-card
CardPreview		 14.374 kB
5.854 kB
react-checkbox
Checkbox		 37.505 kB
12.327 kB
react-combobox
Combobox (including child components)		 91.781 kB
29.935 kB
react-combobox
Dropdown (including child components)		 90.223 kB
29.601 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 70.002 kB
20.161 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 207.417 kB
59.289 kB
react-components
react-components: FluentProvider & webLightTheme		 42.286 kB
14 kB
react-datepicker-compat
DatePicker Compat		 212.494 kB
59.326 kB
react-dialog
Dialog (including children components)		 94.473 kB
28.28 kB
react-divider
Divider		 21.179 kB
7.839 kB
react-field
Field		 22.788 kB
8.639 kB
react-image
Image		 16.096 kB
6.317 kB
react-infobutton
InfoButton		 130.729 kB
41.194 kB
react-infobutton
InfoLabel		 134.413 kB
42.351 kB
react-input
Input		 27.247 kB
9.194 kB
react-jsx-runtime
Classic Pragma		 1.049 kB
531 B
react-jsx-runtime
JSX Dev Runtime		 4.14 kB
1.741 kB
react-jsx-runtime
JSX Runtime		 4.734 kB
1.983 kB
react-label
Label		 14.508 kB
5.857 kB
react-link
Link		 17.4 kB
6.977 kB
react-menu
Menu (including children components)		 140.176 kB
43.004 kB
react-menu
Menu (including selectable components)		 142.862 kB
43.51 kB
react-message-bar
MessageBar (all components)		 25.54 kB
9.102 kB
react-overflow
hooks only		 12.598 kB
4.754 kB
react-persona
Persona		 57.425 kB
17.798 kB
react-popover
Popover		 119.46 kB
37.714 kB
react-portal
Portal		 12.4 kB
4.541 kB
react-portal-compat
PortalCompatProvider		 6.651 kB
2.252 kB
react-positioning
usePositioning		 25.305 kB
9.162 kB
react-progress
ProgressBar		 17.788 kB
6.986 kB
react-provider
FluentProvider		 22.831 kB
8.429 kB
react-radio
Radio		 31.266 kB
10.267 kB
react-radio
RadioGroup		 15.704 kB
6.35 kB
react-select
Select		 28.968 kB
10.269 kB
react-slider
Slider		 38.349 kB
12.595 kB
react-spinbutton
SpinButton		 37.133 kB
11.856 kB
react-spinner
Spinner		 23.762 kB
8.556 kB
react-switch
Switch		 33.731 kB
10.899 kB
react-table
DataGrid		 157.084 kB
43.906 kB
react-table
Table (Primitives only)		 43.941 kB
13.76 kB
react-table
Table as DataGrid		 130.165 kB
35.174 kB
react-table
Table (Selection only)		 75.777 kB
20.477 kB
react-table
Table (Sort only)		 74.384 kB
20.075 kB
react-tags
InteractionTag		 15.618 kB
6.152 kB
react-tags
Tag		 30.341 kB
9.505 kB
react-tags
TagGroup		 73.816 kB
22.097 kB
react-text
Text - Default		 17.065 kB
6.645 kB
react-text
Text - Wrappers		 20.237 kB
6.965 kB
react-textarea
Textarea		 31.306 kB
10.549 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 34.611 kB
7.295 kB
react-theme
Teams: Light theme		 19.282 kB
5.486 kB
react-toast
Toast (including Toaster)		 92.725 kB
27.876 kB
react-tooltip
Tooltip		 52.466 kB
18.466 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against cc35c6608ad5d55c4f0312e688eb4a87aa487937

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 30, 2023 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 30, 2023 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 667 656 5000
Breadcrumb mount 1746 1749 1000
Checkbox mount 1721 1730 5000
CheckboxBase mount 1469 1509 5000
ChoiceGroup mount 3009 3011 5000
ComboBox mount 686 696 1000
CommandBar mount 6399 6436 1000
ContextualMenu mount 15419 15423 1000
DefaultButton mount 756 747 5000
DetailsRow mount 2265 2268 5000
DetailsRowFast mount 2269 2203 5000
DetailsRowNoStyles mount 2048 2077 5000
Dialog mount 2681 2691 1000
DocumentCardTitle mount 235 245 1000
Dropdown mount 2047 2018 5000
FocusTrapZone mount 1153 1140 5000
FocusZone mount 1100 1071 5000
GroupedList mount 42612 42457 2
GroupedList virtual-rerender 18374 20570 2
GroupedList virtual-rerender-with-unmount 51758 51756 2
GroupedListV2 mount 235 229 2
GroupedListV2 virtual-rerender 207 223 2
GroupedListV2 virtual-rerender-with-unmount 241 242 2
IconButton mount 1097 1126 5000
Label mount 343 339 5000
Layer mount 2723 2792 5000
Link mount 396 405 5000
MenuButton mount 974 969 5000
MessageBar mount 22418 22509 5000
Nav mount 2014 1952 1000
OverflowSet mount 807 774 5000
Panel mount 1820 1795 1000
Persona mount 764 789 1000
Pivot mount 895 888 1000
PrimaryButton mount 869 842 5000
Rating mount 4748 4719 5000
SearchBox mount 926 940 5000
Shimmer mount 1910 1924 5000
Slider mount 1337 1319 5000
SpinButton mount 2895 2942 5000
Spinner mount 393 390 5000
SplitButton mount 1871 1877 5000
Stack mount 426 419 5000
StackWithIntrinsicChildren mount 869 862 5000
StackWithTextChildren mount 2621 2654 5000
SwatchColorPicker mount 6274 6217 5000
TagPicker mount 1493 1524 5000
Text mount 387 375 5000
TextField mount 959 988 5000
ThemeProvider mount 866 852 5000
ThemeProvider virtual-rerender 596 599 5000
ThemeProvider virtual-rerender-with-unmount 1306 1292 5000
Toggle mount 616 608 5000
buttonNative mount 201 195 5000

@Hotell Hotell added the CI label Oct 31, 2023
@Hotell Hotell changed the title Enable 1ES PT to be compliant for all production pipelines. ci: Enable 1ES PT to be compliant for all production pipelines. Oct 31, 2023
Hotell
Hotell reviewed Oct 31, 2023
View reviewed changes
azure-pipelines-ci.yml Show resolved Hide resolved
.devops/CredScanSuppressions.json Outdated Show resolved Hide resolved
.devops/CredScanSuppressions.json Show resolved Hide resolved
azure-pipelines-ci.yml Outdated Show resolved Hide resolved
azure-pipelines.yml Show resolved Hide resolved
dannyvv and others added 2 commits October 31, 2023 08:09
dannyvv
dannyvv commented Oct 31, 2023
View reviewed changes
azure-pipelines.yml Outdated Show resolved Hide resolved
@dannyvv dannyvv merged commit a6d0b97 into master Oct 31, 2023
@Hotell Hotell mentioned this pull request Oct 31, 2023
Merged
@Hotell Hotell deleted the 1espt branch October 31, 2023 17:24
@TristanWatanabe TristanWatanabe mentioned this pull request Oct 31, 2023
Merged
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 31, 2023
@marcosmoura
Merge branch 'master' into test/react-drawer/vr-tests
6a9b48c 
* master: (34 commits)
  Remove redundant pipeline yaml. It is now replaced iwth azure-pipelines-ci.yml and azure-pipelines-pr.yml (microsoft#29706)
  chore(TimePicker-compat): preview release with added stories and docs (microsoft#29677)
  Enable 1ES PT to be compliant for all production pipelines (microsoft#29702)
  chore: restrict  node versions to 18 ||| 20 (microsoft#29676)
  chore(TimePicker-compat): renames and code polish (microsoft#29695)
  chore: remove animation from test environments (microsoft#29692)
  applying package updates
  docs: fix defaultSelectedOptions for Dropdown and Combobox examples (microsoft#29700)
  revert accidentally pushed changes (microsoft#29696)
  Added scale factor to minHeight logic (microsoft#29653)
  Fixing the mistake in useArrowNavigationGroup - axis values in the doc (microsoft#29667)
  applying package updates
  🧪
  🧪
  🧪
  🧪
  🧪
  Rever accidentally pushed pipeline changes (microsoft#29685)
  applying package updates
  🧪
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hotell Hotell Hotell approved these changes

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dannyvv @fabricteam @Hotell