Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(TimePicker-compat): add story for custom parsing from time string to date #29707

Merged
merged 6 commits into from
Nov 9, 2023

Conversation

YuanboXue-Amber
Copy link
Contributor

Add story below:
image

@YuanboXue-Amber YuanboXue-Amber marked this pull request as ready for review October 31, 2023 17:28
@YuanboXue-Amber YuanboXue-Amber requested a review from a team as a code owner October 31, 2023 17:28
Copy link

codesandbox-ci bot commented Oct 31, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 83bd9d6:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 31, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-timepicker-compat-preview
TimePicker
93.596 kB
31.349 kB
93.593 kB
31.35 kB
-3 B
1 B

🤖 This report was generated against 8a1688fe1074c03d91c6b42be6ea661cd3e2a381

Copy link

size-auditor bot commented Oct 31, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8a1688fe1074c03d91c6b42be6ea661cd3e2a381 (build)

YuanboXue-Amber and others added 2 commits November 8, 2023 11:20
…ies/TimePicker/TimePickerCustomParsingAndValidation.stories.tsx

Co-authored-by: ling1726 <[email protected]>
@fabricteam
Copy link
Collaborator

fabricteam commented Nov 8, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@YuanboXue-Amber
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@YuanboXue-Amber YuanboXue-Amber enabled auto-merge (squash) November 9, 2023 12:44
@YuanboXue-Amber YuanboXue-Amber merged commit ff6d3f1 into microsoft:master Nov 9, 2023
16 of 20 checks passed
@YuanboXue-Amber YuanboXue-Amber deleted the tag-validation branch November 9, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants