fix: Replace child selectors with css vars in Checkbox styles #29796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 73 | 70 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 672 | 663 | 5000 | |
| Button | mount | 316 | 318 | 5000 | |
| Field | mount | 1142 | 1152 | 5000 | |
| FluentProvider | mount | 722 | 730 | 5000 | |
| FluentProviderWithTheme | mount | 78 | 82 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 73 | 70 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 82 | 79 | 10 | |
| MakeStyles | mount | 867 | 897 | 50000 | |
| Persona | mount | 1778 | 1734 | 5000 | |
| SpinButton | mount | 1359 | 1361 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e96adaf:
|
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: c139fc66cca05255b5c96f6c92d9230b37975276 (build) |
🕵 fluentuiv9 No visual regressions between this PR and main |
ling1726
approved these changes
Nov 9, 2023
spmonahan
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Checkbox styles use the child selector
['> .${checkboxClassNames.indicator}']to set the indicator color based on the hover/selected state of the root slot. This makes it more difficult for users to override the styles.New Behavior
Set the indicator colors using CSS variables on the Checkbox root, and the indicator slot's reset styles reference the CSS variables. Existing style overrides should continue to work, as the new styles have lower specificity.
Related Issue(s)