feat: react-charting legends onchange and defaultSelectedLegends #29799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NewFuture
force-pushed
the
user/newfuture/features/react-cahrting-legends-onchange
branch
from
a369c09 to
acca1b1
Compare
NewFuture
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 88312f9:
|
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
📊 Bundle size report🤖 This report was generated against 69fef129d9fba9bab5824281dd5c2f4fac1291ee |
🕵 fluentuiv8 No visual regressions between this PR and main |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ee8ca9b273641f6fe348338086a7aa29424fbbfb (build) |
NewFuture
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
AtishayMsft
reviewed
Nov 9, 2023
AtishayMsft
reviewed
Nov 9, 2023
AtishayMsft
reviewed
Nov 9, 2023
packages/react-charting/src/components/Legends/Legends.types.ts
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
AtishayMsft
reviewed
Nov 13, 2023
packages/react-charting/src/components/Legends/Legends.base.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Nov 14, 2023
AtishayMsft
reviewed
Nov 14, 2023
AtishayMsft
reviewed
Nov 14, 2023
packages/react-charting/src/components/Legends/Legends.base.tsx
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
krkshitij
reviewed
Nov 14, 2023
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
AtishayMsft
approved these changes
Nov 14, 2023
|
Thanks for the contribution @NewFuture. This PR is merged now. |
krkshitij
reviewed
Nov 14, 2023
| /** | ||
| * Callback issued when the selected option changes. | ||
| */ | ||
| onChange?: (selectedLegends: string[], event: React.MouseEvent<HTMLButtonElement>, currentLegend?: ILegend) => void; |
There was a problem hiding this comment.
Can be renamed to something like onLegendSelectionChange for better clarity
There was a problem hiding this comment.
onChange is a common naming for input controllers.
NewFuture
deleted the
user/newfuture/features/react-cahrting-legends-onchange
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add new props into the Legends.
onChange: Callback issued when the selected option changes.defaultSelectedLegends: Keys that will be initially used to set selected items.defaultSelectedLegend: Key for single selection.changes:
Related Issue(s)
#29651