Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: React Charting Heat Map Chart tooltip appears above the wrong cell #29800

Merged
merged 6 commits into from
Nov 9, 2023

Conversation

harsh9975
Copy link
Contributor

Screen.Recording.2023-11-09.at.4.40.01.PM.mov

Previous Behavior

When you hover over a cell in the heat map, a tooltip appears. It is supposed to appear above that cell. However, for certain cells, it appears above the wrong cell.

New Behavior

There was a small issue whenever we are hovering over index [1,10] the tooltip was showing in [11,0] cell. reason earlier it was storing both the index as string 110 and 110 which created the conflict. however i have addded x1y10 and x11y0 to differentiate.

Related Issue(s)

#29740
#29741

  • Fixes #

@harsh9975 harsh9975 requested a review from a team as a code owner November 9, 2023 11:26
@harsh9975 harsh9975 changed the title [Bug]: React Charting Heat Map Chart tooltip appears above the wrong … [Bug]: React Charting Heat Map Chart tooltip appears above the wrong cell Nov 9, 2023
@harsh9975
Copy link
Contributor Author

#29740

@harsh9975 harsh9975 changed the title [Bug]: React Charting Heat Map Chart tooltip appears above the wrong cell [Fix]: React Charting Heat Map Chart tooltip appears above the wrong cell Nov 9, 2023
@harsh9975
Copy link
Contributor Author

#29741

@harsh9975
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link

codesandbox-ci bot commented Nov 9, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 30757e7:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@AtishayMsft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 9, 2023

📊 Bundle size report

🤖 This report was generated against 9000e9af6731db4c76c13715fd5611bc5c4c9598

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 9, 2023

🕵 fluentuiv8 No visual regressions between this PR and main

Copy link

size-auditor bot commented Nov 9, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 9000e9af6731db4c76c13715fd5611bc5c4c9598 (build)

george-cz and others added 2 commits November 9, 2023 21:21
@harsh9975 harsh9975 requested a review from a team as a code owner November 9, 2023 15:51
@harsh9975 harsh9975 requested a review from AtishayMsft November 9, 2023 15:55
@AtishayMsft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@AtishayMsft AtishayMsft merged commit 9c30220 into microsoft:master Nov 9, 2023
20 checks passed
@AtishayMsft
Copy link
Contributor

@harsh9975 This fix is merged. Thanks for your contribution. Do let me know if you are interested to contribute to fix more issues in the fluent react charting library. We welcome contributions from the community.

@harsh9975
Copy link
Contributor Author

@AtishayMsft yes, I am interested in contributing to more fixes.

@AtishayMsft
Copy link
Contributor

AtishayMsft commented Nov 9, 2023

@harsh9975 - Great. Feel free to join the fluent charting community @ https://aka.ms/FluentCharting/discord . We can discuss about few pending issues there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants