fix: Breadcrumb uses button when no href is present, tooltip labels button #29803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinaKozlova
approved these changes
Nov 9, 2023
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1f55e86:
|
📊 Bundle size report🤖 This report was generated against f500d2bd42ac9f6bd6b162f7f7271ac13a1426b9 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f500d2bd42ac9f6bd6b162f7f7271ac13a1426b9 (build) |
🕵 fluentuiv9 No visual regressions between this PR and main |
smhigley
force-pushed
the
breadcrumb-a11y
branch
from
cee968d to
1f55e86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
We had focusable
<a>tags with nohref, which is semantically the same as a<span>. We could also potentially addrole=link, but it seems better to render items with nohrefor explicitasas a<button>.This also makes a minor story fix to make
<Tooltip>directly wrap<BreadcrumbButton>so that thearia-labelis being applied to the correct element.