-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: export type EventHandler/EventData from react-utilities for typing callback props #30322
Merged
YuanboXue-Amber
merged 4 commits into
microsoft:master
from
YuanboXue-Amber:export-new-type
Jan 17, 2024
Merged
chore: export type EventHandler/EventData from react-utilities for typing callback props #30322
YuanboXue-Amber
merged 4 commits into
microsoft:master
from
YuanboXue-Amber:export-new-type
Jan 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuanboXue-Amber
changed the title
Export new type
chore: export type EventHandler/EventData from react-utilities for typing callback props
Jan 16, 2024
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 619 | 647 | 5000 | |
Button | mount | 298 | 301 | 5000 | |
Field | mount | 1118 | 1092 | 5000 | |
FluentProvider | mount | 691 | 719 | 5000 | |
FluentProviderWithTheme | mount | 87 | 85 | 10 | |
FluentProviderWithTheme | virtual-rerender | 75 | 76 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 79 | 79 | 10 | |
MakeStyles | mount | 842 | 875 | 50000 | |
Persona | mount | 1751 | 1751 | 5000 | |
SpinButton | mount | 1435 | 1409 | 5000 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c3aa4af:
|
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 0c422edc87177d3d707c71fa3cad3fa2b872bdf8 (build) |
🕵 fluentuiv9 No visual regressions between this PR and main |
layershifter
approved these changes
Jan 16, 2024
bsunderhus
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
We agreed on new event type for v9 callbacks.
Below types will be exported from react-utilities as helpers:
And they will be used for typing callbacks:
detailed proposal: https://github.com/microsoft/fluentui/blob/master/rfcs/react-components/convergence/event-handlers-event-type.md
This PR does:
Export the helper types as mentioned above.
To make sure this type is used, PR #30293 adds lint rule to force its usage, and PR #30301 deprecates
consistent-callback-args
test that checks for older callback types.