-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-aria): active descendants imperative handle to toggle attribute visibility #30716
Merged
bsunderhus
merged 1 commit into
microsoft:master
from
bsunderhus:react-aria/feat--active-descendants-imperative-handle-to-toggle-attribute
Mar 5, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 614 | 626 | 5000 | |
Button | mount | 305 | 305 | 5000 | |
Field | mount | 1119 | 1157 | 5000 | |
FluentProvider | mount | 722 | 711 | 5000 | |
FluentProviderWithTheme | mount | 89 | 92 | 10 | |
FluentProviderWithTheme | virtual-rerender | 77 | 63 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 83 | 74 | 10 | |
MakeStyles | mount | 911 | 864 | 50000 | |
Persona | mount | 1787 | 1747 | 5000 | |
SpinButton | mount | 1385 | 1348 | 5000 |
bsunderhus
force-pushed
the
react-aria/feat--active-descendants-imperative-handle-to-toggle-attribute
branch
from
March 5, 2024 13:49
4aaca32
to
e53fe69
Compare
bsunderhus
force-pushed
the
react-aria/feat--active-descendants-imperative-handle-to-toggle-attribute
branch
from
March 5, 2024 14:00
e53fe69
to
2638a16
Compare
ling1726
approved these changes
Mar 5, 2024
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
🕵 fluentuiv9 No visual regressions between this PR and main |
bsunderhus
deleted the
react-aria/feat--active-descendants-imperative-handle-to-toggle-attribute
branch
March 5, 2024 14:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
showAttributes
andhideAttributes
method toActiveDescendantImperativeRef
Related Issue(s)
NVDA and JAWS have bugs that suppress reading the input value text when
aria-activedescendant
is set.To prevent this, the HTML attribute should be removed when a user presses left/right arrows (#26359 (comment)).