Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-aria): active descendants imperative handle to toggle attribute visibility #30716

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Mar 5, 2024

New Behavior

  1. provides showAttributes and hideAttributes method to ActiveDescendantImperativeRef
  2. adds test to ensure behaviour

Related Issue(s)

NVDA and JAWS have bugs that suppress reading the input value text when aria-activedescendant is set.
To prevent this, the HTML attribute should be removed when a user presses left/right arrows (#26359 (comment)).

@bsunderhus bsunderhus self-assigned this Mar 5, 2024
@github-actions github-actions bot added this to the March Project Cycle Q1 2024 milestone Mar 5, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Mar 5, 2024

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-combobox
Combobox (including child components)
102.463 kB
33.101 kB
102.688 kB
33.177 kB
225 B
76 B
react-combobox
Dropdown (including child components)
103.837 kB
33.038 kB
104.062 kB
33.104 kB
225 B
66 B
react-timepicker-compat
TimePicker
104.484 kB
34.49 kB
104.709 kB
34.56 kB
225 B
70 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)
100.127 kB
30.426 kB
react-alert
Alert
83.737 kB
23.474 kB
react-avatar
Avatar
50.175 kB
15.944 kB
react-avatar
AvatarGroup
19.704 kB
7.796 kB
react-avatar
AvatarGroupItem
64.831 kB
20.274 kB
react-breadcrumb
@fluentui/react-breadcrumb - package
115.48 kB
31.84 kB
react-button
Button
39.513 kB
11.169 kB
react-button
CompoundButton
46.874 kB
12.661 kB
react-button
MenuButton
44.292 kB
12.542 kB
react-button
SplitButton
52.306 kB
14.134 kB
react-button
ToggleButton
56.559 kB
13.068 kB
react-card
Card - All
101.557 kB
28.932 kB
react-card
Card
96.382 kB
27.401 kB
react-card
CardFooter
13.064 kB
5.385 kB
react-card
CardHeader
15.307 kB
6.143 kB
react-card
CardPreview
14.015 kB
5.752 kB
react-components
react-components: Button, FluentProvider & webLightTheme
71.098 kB
20.514 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
217.207 kB
61.943 kB
react-components
react-components: FluentProvider & webLightTheme
43.585 kB
14.351 kB
react-datepicker-compat
DatePicker Compat
224.523 kB
62.939 kB
react-dialog
Dialog (including children components)
100.93 kB
29.924 kB
react-infobutton
InfoButton
138.696 kB
43.398 kB
react-infobutton
InfoLabel
142.497 kB
44.627 kB
react-menu
Menu (including children components)
149.428 kB
45.509 kB
react-menu
Menu (including selectable components)
152.114 kB
46.021 kB
react-message-bar
MessageBar (all components)
25.566 kB
9.131 kB
react-persona
Persona
57.066 kB
17.821 kB
react-popover
Popover
126.886 kB
39.806 kB
react-portal-compat
PortalCompatProvider
7.944 kB
2.588 kB
react-table
DataGrid
165.191 kB
45.909 kB
react-table
Table (Primitives only)
45.324 kB
14.116 kB
react-table
Table as DataGrid
136.573 kB
36.817 kB
react-table
Table (Selection only)
76.334 kB
20.552 kB
react-table
Table (Sort only)
74.977 kB
20.154 kB
react-tags
InteractionTag
15.259 kB
6.058 kB
react-tags
Tag
29.982 kB
9.439 kB
react-tags
TagGroup
80.556 kB
24.027 kB
react-toast
Toast (including Toaster)
100.198 kB
29.76 kB
🤖 This report was generated against 931d37d4de92096827a7aafdde8f16e197ea24af

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 5, 2024

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 614 626 5000
Button mount 305 305 5000
Field mount 1119 1157 5000
FluentProvider mount 722 711 5000
FluentProviderWithTheme mount 89 92 10
FluentProviderWithTheme virtual-rerender 77 63 10
FluentProviderWithTheme virtual-rerender-with-unmount 83 74 10
MakeStyles mount 911 864 50000
Persona mount 1787 1747 5000
SpinButton mount 1385 1348 5000

@bsunderhus bsunderhus force-pushed the react-aria/feat--active-descendants-imperative-handle-to-toggle-attribute branch from 4aaca32 to e53fe69 Compare March 5, 2024 13:49
@bsunderhus bsunderhus marked this pull request as ready for review March 5, 2024 13:49
@bsunderhus bsunderhus requested a review from a team as a code owner March 5, 2024 13:49
@bsunderhus bsunderhus force-pushed the react-aria/feat--active-descendants-imperative-handle-to-toggle-attribute branch from e53fe69 to 2638a16 Compare March 5, 2024 14:00
Copy link

codesandbox-ci bot commented Mar 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus merged commit 6fcb840 into microsoft:master Mar 5, 2024
19 checks passed
@bsunderhus bsunderhus deleted the react-aria/feat--active-descendants-imperative-handle-to-toggle-attribute branch March 5, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants