-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Collapse): create CollapseDelayed variant #33069
Merged
robertpenner
merged 8 commits into
microsoft:master
from
robertpenner:feat/collapse-delay
Oct 21, 2024
Merged
feat(Collapse): create CollapseDelayed variant #33069
robertpenner
merged 8 commits into
microsoft:master
from
robertpenner:feat/collapse-delay
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 664 | 615 | 5000 | |
Button | mount | 300 | 295 | 5000 | |
Field | mount | 1119 | 1117 | 5000 | |
FluentProvider | mount | 719 | 737 | 5000 | |
FluentProviderWithTheme | mount | 88 | 76 | 10 | |
FluentProviderWithTheme | virtual-rerender | 32 | 38 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 73 | 72 | 10 | |
MakeStyles | mount | 875 | 871 | 50000 | |
Persona | mount | 1773 | 1740 | 5000 | |
SpinButton | mount | 1378 | 1376 | 5000 | |
SwatchPicker | mount | 1684 | 1671 | 5000 |
fabricteam
reviewed
Oct 17, 2024
change/@fluentui-react-motion-components-preview-b271a894-6660-439a-aef6-8f008b144e56.json
Outdated
Show resolved
Hide resolved
a05a1a7
to
ef124fd
Compare
d60c1ee
to
49c15c0
Compare
8f50986
to
f184f48
Compare
pixel-perfectionist
approved these changes
Oct 21, 2024
...components/react-motion-components-preview/library/src/components/Collapse/collapse-atoms.ts
Show resolved
Hide resolved
layershifter
approved these changes
Oct 21, 2024
/azp run license/cla |
No pipelines are associated with this pull request. |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Collapse
animates size (height or width) and opacity in sync: they start together and have the same duration.New Behavior
CollapseDelayed
is a new variant that animates size and opacity separately:Documentation
CollapseDelayed
example in Storybook.Refactoring
Collapse
motion atom objects to reusable factory functions and moved them to a separate file.Collapse
types to a separate file as well.Related Issue(s)