N/M variant of HBC #33078
Closed
N/M variant of HBC #33078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtishayMsft
reviewed
Oct 18, 2024
| @@ -13,6 +13,12 @@ export default { | |||
|
|
|||
| export const Basic: Story<FluentHorizontalBarChart> = renderComponent(storyTemplate).bind({}); | |||
|
|
|||
| export const NMVariant: Story<FluentHorizontalBarChart> = renderComponent(html<StoryArgs<FluentHorizontalBarChart>>` | |||
| <div> | |||
| <fluent-horizontalbarchart variant="part-to-whole"> </fluent-horizontalbarchart> | |||
There was a problem hiding this comment.
use this as an enum similar to absolute variant
There was a problem hiding this comment.
Enum is already defined. This is passed as an attribute similar to prop that we used in React.
AtishayMsft
reviewed
Oct 18, 2024
| const getChartData = () => (data!.chartData![0].data ? data!.chartData![0].data : 0); | ||
|
|
||
| if (showRatio) { | ||
| const ratioDiv = chartTitleDiv.append('div').attr('role', 'text'); |
There was a problem hiding this comment.
Where is the data for the image that you shared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Added N/M variant of Multi Stacked Horizontal bar chart.
Related Issue(s)