Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Motion components storybook updates #33133

Conversation

pixel-perfectionist
Copy link
Member

@pixel-perfectionist pixel-perfectionist commented Oct 24, 2024

New Behavior

This PR updates the Collapse component documentation to clarify that it extends createPresenceComponent and inherits additional props and callbacks.

•	Added reference to createPresenceComponent props in Collapse docs.
•	Linked to the Presence Component Storybook page for further details.
SCR-20241024-jrfe

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 24, 2024

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 666 656 5000
Button mount 307 303 5000
Field mount 1129 1126 5000
FluentProvider mount 721 716 5000
FluentProviderWithTheme mount 91 91 10
FluentProviderWithTheme virtual-rerender 35 34 10
FluentProviderWithTheme virtual-rerender-with-unmount 75 87 10
MakeStyles mount 840 867 50000
Persona mount 1793 1731 5000
SpinButton mount 1358 1375 5000
SwatchPicker mount 1699 1669 5000

@pixel-perfectionist pixel-perfectionist marked this pull request as ready for review October 25, 2024 22:03
@pixel-perfectionist pixel-perfectionist requested a review from a team as a code owner October 25, 2024 22:03
@pixel-perfectionist pixel-perfectionist force-pushed the olkatruk/motion-documentation branch 6 times, most recently from 9183863 to 7ca592e Compare October 30, 2024 20:15
@pixel-perfectionist pixel-perfectionist changed the title fix(docs): Collapse storybook updates fix(docs): Motion components storybook updates Oct 30, 2024
@pixel-perfectionist pixel-perfectionist force-pushed the olkatruk/motion-documentation branch from 7ca592e to b8083a6 Compare October 30, 2024 20:17
@pixel-perfectionist pixel-perfectionist merged commit b09b45c into microsoft:master Oct 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Collapse] Review documentation and update as needed
3 participants