Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving mouse hover behavior in Line Chart #33261

Open
wants to merge 122 commits into
base: master
Choose a base branch
from
Open

Improving mouse hover behavior in Line Chart #33261

wants to merge 122 commits into from

Conversation

srmukher
Copy link
Contributor

Issue: Whenever the mouse is hovered on the Line Chart, the Popover moves along with the mouse even if no new points are highlighted in the chart.

Following are the results after addressing the issues:

  1. The popover now remains stationary once rendered for a data point. It only changes position if dismissed or if the mouse hovers over another data point.
  2. The number of re-renders has been significantly reduced, from 187 to 19.

AtishayMsft and others added 30 commits May 6, 2024 10:37
@AtishayMsft
Draft implementation of charts in v9
010b227
@AtishayMsft
Update tsconfig
bd8c925
@AtishayMsft
Resolve errors
bd13f03
@AtishayMsft
Update react popover package version
eada51d
@AtishayMsft
Enable horizontal bar chart. Without focus zone and callout.
6568f1b
@AtishayMsft
Enable tabster based focus behavior for Horizontal Bar Chart
62199f2
@srmukher
Popover for HorizontalBarChart (#31774)
2382caf
@Anush2303
sparkline V9 (#31785)
8583df3 
Co-authored-by: Anush <[email protected]>
@Anush2303
Testing of Sparkline and HBC (#31952)
b247ff3 
Co-authored-by: Anush <[email protected]>
@srmukher
Migrating Donut chart to v9 (#31948)
3c51973
@Anush2303
cartesian chart in V9 (#31983)
e6ec5ce
@Anush2303
vertical bar chart in V9 (#31924)
6c47984
@Anush2303
line chartV9 (#31884)
91555d0
@AtishayMsft
Merge master
e26e0d5
@AtishayMsft
Update package dependencies to latest as per master
09c0144
@AtishayMsft
Fix dependency versions as per other components
c99c081
@AtishayMsft
Disable package version mismatch by overriding syncpack config
f115763
@AtishayMsft
Override d3 version dependency mismatch while standing up v9
d585efb
@v-asurse
Adding the Sparkline chart unit testcase into the chartsV9. (#32090)
29c9b35
@Anush2303
Cartesian V9 Migration (#32178)
ecfd51c
@srmukher
Legend component V9 (#32134)
6baf6d7
@Anush2303
line chart Overflow fix (#32225)
dbb7835
@Anush2303
Style fixes for VBC (#32245)
4b816bf
@Anush2303
Line issue and Rotated labels fix (#32259)
11c401b
@srmukher
Popover for Cartesian charts v9 (#32249)
28f1d11
@AtishayMsft
Remove charts not planned in this releae
ff42a4f
@srmukher
Enabling popover for Vertical bar chart (#32266)
933a603
@AtishayMsft
Resolve build errors in chart controls
70f8959
@AtishayMsft
Merge branch 'usr/atisjai/chartsV9' of https://github.com/microsoft/f…
c943067 
…luentui into usr/atisjai/chartsV9
@AtishayMsft
Fix build errors
f5d5c59
AtishayMsft and others added 27 commits October 10, 2024 16:11
@AtishayMsft
Fix window undefined issue
68447bc
@AtishayMsft
Remove all stories from ssr tests
7504eca
@AtishayMsft
Fix lint errors
cf35ede
@AtishayMsft
Fix lint errors
0c291ec
@AtishayMsft
Fix lint errors
d571be0
@AtishayMsft
Update doc comment
b3451a0
@AtishayMsft
Fix type check errors
a560d8e
@AtishayMsft
Update test snapshots
2de2a1e
@AtishayMsft
Update API file
643ed88
@AtishayMsft
Fix type check in stories
2e58bf7
@AtishayMsft
Make charts ESM based
37ebb82
@AtishayMsft
Fix test
fc3e74a
@AtishayMsft
Merge branch 'master' into usr/atisjai/chartsV9
96d4457
@AtishayMsft
Update VR stories
1071e3d
@srmukher
Fixing styles for custom callout stories (#33054)
ed80ac6
@srmukher
Fixing alignment issue of legends (#33072)
74dbfba
@AtishayMsft
Remove I prefix from interfaces
1066091
@AtishayMsft
Merge branch 'usr/atisjai/chartsV9' of https://github.com/microsoft/f…
11d2637 
…luentui into usr/atisjai/chartsV9
@AtishayMsft
Fix vr test interfaces
000d854
@AtishayMsft
Address review comments
8fa237e
@srmukher
Making changes for Popover component (#33089)
1c9257c
@srmukher
Fixing build errors in V9 (#33099)
fed36fc
@AtishayMsft
Usr/atisjai/charts v9move (#33107)
9ccfbe5
@AtishayMsft
Resolve review comments
c00134c
@srmukher
Styled example for Donut chart (#33159)
3584d01
@srmukher
Fixing High Contrast Bugs - Part 1 (#33170)
b07a010
@srmukher
Improving mouse hover behaviour in Line Chart
b1527a7
@srmukher srmukher requested a review from a team as a code owner November 12, 2024 16:24
@github-actions GitHub Actions
Copy link

Pull request demo site: URL

Base automatically changed from usr/atisjai/chartsV9 to master November 14, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@srmukher @AtishayMsft @Anush2303 @v-asurse @krkshitij