Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin-react-components): add prefer-fluentui-v9 rule #33449

Merged

Conversation

dmytrokirpa
Copy link
Contributor

Previous Behavior

--

New Behavior

  • Added new rule prefer-fluentui-v9 to eslint-plugin-react-components to enforce the use of Fluent UI v9 equivalent for Fluent UI v8 components.
  • Added it to the recommended config.
  • Updated docs

Example of output:

fluentui/apps/vr-tests/src/stories/Toggle.stories.tsx
  4:1  warning  Avoid importing Toggle from '@fluentui/react', as this package has already migrated to Fluent UI 9. Import Switch from '@fluentui/react-components' instead  @fluentui/react-components/prefer-fluentui-v9

fluentui/apps/vr-tests/src/stories/Tooltip/Tooltip.stories.tsx
  4:1  warning  Avoid importing TooltipHost from '@fluentui/react', as this package has already migrated to Fluent UI 9. Import Tooltip from '@fluentui/react-components' instead  @fluentui/react-components/prefer-fluentui-v9

Related Issue(s)

Copy link

github-actions bot commented Dec 11, 2024

📊 Bundle size report

✅ No changes found

@dmytrokirpa
Copy link
Contributor Author

cc @NotWoods

Copy link

Pull request demo site: URL

@dmytrokirpa dmytrokirpa requested a review from Hotell December 30, 2024 17:05
@dmytrokirpa dmytrokirpa enabled auto-merge (squash) December 31, 2024 14:57
Copy link
Contributor

@Hotell Hotell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments that need to be addressed as part of PR but others can be a follow-up. approving to unblock once the change file is tweaked.

stoked to have 1st rule being shipped soon !
ty

@dmytrokirpa dmytrokirpa force-pushed the feat/add-eslint-rule-prefer-v9 branch from c95aa44 to 13b62f8 Compare January 7, 2025 13:41
@dmytrokirpa dmytrokirpa force-pushed the feat/add-eslint-rule-prefer-v9 branch from 41169b0 to 4e1f423 Compare January 7, 2025 13:44
@dmytrokirpa dmytrokirpa enabled auto-merge (squash) January 7, 2025 13:45
@dmytrokirpa dmytrokirpa merged commit 384df0c into microsoft:master Jan 7, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants