-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin-react-components): add prefer-fluentui-v9 rule #33449
Merged
dmytrokirpa
merged 10 commits into
microsoft:master
from
dmytrokirpa:feat/add-eslint-rule-prefer-v9
Jan 7, 2025
Merged
feat(eslint-plugin-react-components): add prefer-fluentui-v9 rule #33449
dmytrokirpa
merged 10 commits into
microsoft:master
from
dmytrokirpa:feat/add-eslint-rule-prefer-v9
Jan 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
cc @NotWoods |
Pull request demo site: URL |
NotWoods
suggested changes
Dec 11, 2024
packages/react-components/eslint-plugin-react-components/src/rules/prefer-fluentui-v9.ts
Outdated
Show resolved
Hide resolved
packages/react-components/eslint-plugin-react-components/src/rules/prefer-fluentui-v9.ts
Outdated
Show resolved
Hide resolved
NotWoods
reviewed
Dec 11, 2024
packages/react-components/eslint-plugin-react-components/src/rules/prefer-fluentui-v9.ts
Outdated
Show resolved
Hide resolved
NotWoods
reviewed
Dec 11, 2024
packages/react-components/eslint-plugin-react-components/src/rules/prefer-fluentui-v9.ts
Outdated
Show resolved
Hide resolved
packages/react-components/eslint-plugin-react-components/src/rules/prefer-fluentui-v9.ts
Show resolved
Hide resolved
packages/react-components/eslint-plugin-react-components/src/rules/prefer-fluentui-v9.ts
Outdated
Show resolved
Hide resolved
packages/react-components/eslint-plugin-react-components/src/rules/prefer-fluentui-v9.ts
Outdated
Show resolved
Hide resolved
packages/react-components/eslint-plugin-react-components/src/rules/prefer-fluentui-v9.ts
Outdated
Show resolved
Hide resolved
dmytrokirpa
requested review from
NotWoods and
mainframev
and removed request for
NotWoods
December 12, 2024 11:16
NotWoods
approved these changes
Dec 12, 2024
packages/react-components/eslint-plugin-react-components/README.md
Outdated
Show resolved
Hide resolved
...es/react-components/eslint-plugin-react-components/etc/eslint-plugin-react-components.api.md
Outdated
Show resolved
Hide resolved
packages/react-components/eslint-plugin-react-components/src/rules/prefer-fluentui-v9.ts
Outdated
Show resolved
Hide resolved
NotWoods
approved these changes
Dec 13, 2024
mainframev
reviewed
Dec 31, 2024
packages/react-components/eslint-plugin-react-components/src/rules/prefer-fluentui-v9.ts
Outdated
Show resolved
Hide resolved
mainframev
approved these changes
Dec 31, 2024
Hotell
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments that need to be addressed as part of PR but others can be a follow-up. approving to unblock once the change file is tweaked.
stoked to have 1st rule being shipped soon !
ty
packages/react-components/eslint-plugin-react-components/src/index.ts
Outdated
Show resolved
Hide resolved
packages/react-components/eslint-plugin-react-components/src/rules/prefer-fluentui-v9.ts
Outdated
Show resolved
Hide resolved
packages/react-components/eslint-plugin-react-components/tsconfig.spec.json
Show resolved
Hide resolved
packages/react-components/eslint-plugin-react-components/src/rules/prefer-fluentui-v9.ts
Outdated
Show resolved
Hide resolved
packages/react-components/eslint-plugin-react-components/src/rules/prefer-fluentui-v9.ts
Show resolved
Hide resolved
packages/react-components/eslint-plugin-react-components/src/rules/prefer-fluentui-v9.ts
Show resolved
Hide resolved
change/@fluentui-eslint-plugin-react-components-1c2bc691-c857-43cf-9806-ffe8d0d058c0.json
Outdated
Show resolved
Hide resolved
dmytrokirpa
force-pushed
the
feat/add-eslint-rule-prefer-v9
branch
from
January 2, 2025 15:09
6c824b5
to
0679d93
Compare
dmytrokirpa
force-pushed
the
feat/add-eslint-rule-prefer-v9
branch
from
January 7, 2025 13:41
c95aa44
to
13b62f8
Compare
dmytrokirpa
force-pushed
the
feat/add-eslint-rule-prefer-v9
branch
from
January 7, 2025 13:44
41169b0
to
4e1f423
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
--
New Behavior
prefer-fluentui-v9
toeslint-plugin-react-components
to enforce the use of Fluent UI v9 equivalent for Fluent UI v8 components.recommended
config.Example of output:
Related Issue(s)