-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(MessageBar): migrate slide & fade to motion components #33465
Merged
robertpenner
merged 25 commits into
microsoft:master
from
robertpenner:refactor/messagebar-slide
Dec 20, 2024
Merged
refactor(MessageBar): migrate slide & fade to motion components #33465
robertpenner
merged 25 commits into
microsoft:master
from
robertpenner:refactor/messagebar-slide
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size reportUnchanged fixtures
|
Pull request demo site: URL |
be4e312
to
8e80f7a
Compare
8e80f7a
to
3b9ff97
Compare
55fabac
to
d4bfcac
Compare
fabricteam
reviewed
Dec 13, 2024
change/@fluentui-react-message-bar-72abc821-ab32-4cac-8dd2-4c8dce4c810e.json
Show resolved
Hide resolved
ling1726
reviewed
Dec 13, 2024
packages/react-components/react-message-bar/library/src/contexts/messageBarTransitionContext.ts
Outdated
Show resolved
Hide resolved
ling1726
previously requested changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking for a breaking change, to make sure it does not accidentally get merged
9fe67fb
to
19bcb85
Compare
- based on code review
19bcb85
to
551a4a4
Compare
35cbf40
to
426e458
Compare
.../react-message-bar/library/src/components/MessageBarGroup/useMessageBarGroupStyles.styles.ts
Outdated
Show resolved
Hide resolved
...ponents/react-message-bar/library/src/components/MessageBarGroup/MessageBarGroup.motions.tsx
Outdated
Show resolved
Hide resolved
...components/react-message-bar/library/src/components/MessageBarGroup/MessageBarGroup.types.ts
Outdated
Show resolved
Hide resolved
...omponents/react-message-bar/library/src/components/MessageBarGroup/renderMessageBarGroup.tsx
Outdated
Show resolved
Hide resolved
e1b26d4
to
0dc7242
Compare
- yarn nx format:check --base origin/master
0dc7242
to
e55b7bb
Compare
…arMotion component - Otherwise, when state.animate changes, an elementType will change and React will remount a part of a tree, and children will loose their state
…component - This helps the React tree reconciliation, by keeping the React element type from changing.
layershifter
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MessageBarGroup
Previous Behavior
MessageBarGroup
animations were implemented usingreact-transition-group
and CSS.New Behavior
MessageBarGroup
animations use motion components in a PresenceGroup.react-transition-group
dependency is removed... from all of v9!react-components
is 7 kB smaller.MessageBarTransition.tsx
is deleted.Testing Notes
MessageBar
Animation example. (PR build)Related Issue(s)