Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-tag-picker): modify roles for toolbar + buttons instead of listbox + options #33487

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Dec 18, 2024

Previous Behavior

TagPickerGroup is currently using listbox role and all the Tags components inside of it follow along with option roles. Due to new design decisions we have scenarios where this combination of roles might not suffice

New Behavior

Modifies the roles of TagPickerGroup for toolbar and Tags for button, which is flexible enough for the new design specs

Related Issue(s)

  • Fixes #

@bsunderhus bsunderhus self-assigned this Dec 18, 2024
Copy link

github-actions bot commented Dec 18, 2024

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library
1.164 MB
291.232 kB
1.164 MB
291.229 kB
-15 B
-3 B
react-tag-picker
@fluentui/react-tag-picker - package
185.227 kB
55.684 kB
185.212 kB
55.681 kB
-15 B
-3 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.21 kB
20.174 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
222.703 kB
64.42 kB
react-components
react-components: FluentProvider & webLightTheme
44.447 kB
14.59 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-timepicker-compat
TimePicker
108.525 kB
36.087 kB
🤖 This report was generated against 5964b11d0ac272f2ae10e1081b8f0d1e17497eef

@bsunderhus bsunderhus marked this pull request as ready for review December 18, 2024 12:25
@bsunderhus bsunderhus requested a review from a team as a code owner December 18, 2024 12:25
@bsunderhus bsunderhus changed the title chore: modify roles for toolbar + buttons instead of listbox + options chore(react-tag-picker): modify roles for toolbar + buttons instead of listbox + options Dec 18, 2024
Copy link

Pull request demo site: URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants