[Compatibility] Added LCS command #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nicely done!! |
TalZaccai
requested changes
Dec 6, 2024
|
@TalZaccai Fixed review command with an open question |
|
Might be a good idea to perf test these commands, varying #threads: another example:
|
|
I don't think I have proper setup to run Data Load LCS GET @badrishc @TalZaccai Provided the inconsistency with my setup of Feel free to guide me in the right direction if I am doing something wrong with |
TalZaccai
approved these changes
Jan 7, 2025
kevin-montrose
pushed a commit
that referenced
this pull request
Jan 15, 2025
* Added LCS command * Format fix * Reverted CommandDocsUpdater.cs * Fix cluster test * Fixed wrong change * Moved to constant * Review command fixes * Fixed review comment * Fixed test issue --------- Co-authored-by: Vasileios Zois <[email protected]> Co-authored-by: Tal Zaccai <[email protected]>
darrenge
added a commit
that referenced
this pull request
Jan 16, 2025
* Lua allocations go through .NET; really crummy allocator on the POH just to prove it's possible; squashing to clean up _a lot_ of experimentation commits * punch a LuaOptions into settings * wire up the Lua options * prep for other allocators * Implement more allocators and expand testing * Knock out a number of todos, consider allocator in benchmarks, additional validation * add a test for OOMs * formatting * convert ScriptOperations to explore different allocators * cleanup Lua error messgages; this revealed a bug in buffer management for LuaScripts, fixes that * Make managed allocator less naive, and benchmark on par. It will probably be unusual to use this allocator, but it shouldn't be _bad_ either. * formatting * address nit * address feedback; only copy relevant bits, not whole buffer * set lua options in OperationsBase, fixing benchmarks * BDN Updates: 1) Added a check for NA in results which is an indication that the BDN test failed at run time 2) Added 'Lua.LuaScriptCacheOperations','Lua.LuaRunnerOperations' to BDN Github Action 3) Updated Expected values for the new Lua BDN tests * Updated some of the LuaScriptCacheOperations expected values * [Compatibility] Added LCS command (#843) * Added LCS command * Format fix * Reverted CommandDocsUpdater.cs * Fix cluster test * Fixed wrong change * Moved to constant * Review command fixes * Fixed review comment * Fixed test issue --------- Co-authored-by: Vasileios Zois <[email protected]> Co-authored-by: Tal Zaccai <[email protected]> * Configure min and max IO completion threads (#904) * Configure min and max IO completion threads separately from min and max threads (in the ThreadPool). This is needed as some scenarios may limit number of thread pool threads but require a larger number of IO completion threads. * nit * address nit * address feedback; only copy relevant bits, not whole buffer * set lua options in OperationsBase, fixing benchmarks * Yak shave a bunch of cleanup, looking to reduce amount of work done generally in Lua to get some perf back. * formatting * fix LuaRunnerOperations ; session wouldn't always be initialized before, which would cause SendAndReset() to fail thinking the message was too large * Updated Expected values for Allocated in the BDN perf tests to match current Lua changes. * Missed one expected value. Fixed that so should be ok. * Seen some instances where allocated bytes are 1024 on one run and then run it a second time and see 1312 without any code changes. Just a small variance between runs so decided to just make sure doesn't go above 1312 for any that were set to 1024. The charts and other things will show the small nuances if needed. * Bumped expected values up a bit to handle variance --------- Co-authored-by: darrenge <[email protected]> Co-authored-by: Vijay Nirmal <[email protected]> Co-authored-by: Vasileios Zois <[email protected]> Co-authored-by: Tal Zaccai <[email protected]> Co-authored-by: Badrish Chandramouli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the LCS commands to garnet