Fix inputSourceMap Babel error (#466)

* Replace null inputSourceMap with undefined * Change files * Update change message * fix extraction loader, too * Change files --------- Co-authored-by: Alina Zaieva <[email protected]> Co-authored-by: Oleksandr Fediashov <[email protected]>
microsoft · Nov 13, 2023 · dbbdcb6 · dbbdcb6
1 parent 8066a39
commit dbbdcb6
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 2 deletions.
diff --git a/change/@griffel-webpack-extraction-plugin-593a69cc-cc81-40f5-af41-6bce970f9e8f.json b/change/@griffel-webpack-extraction-plugin-593a69cc-cc81-40f5-af41-6bce970f9e8f.json
@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix: replace null inputSourceMap with undefined",
+  "packageName": "@griffel/webpack-extraction-plugin",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}
diff --git a/change/@griffel-webpack-loader-0c8121e6-efb9-45f6-bba1-42cfc2b86834.json b/change/@griffel-webpack-loader-0c8121e6-efb9-45f6-bba1-42cfc2b86834.json
@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix: replace null inputSourceMap with undefined",
+  "packageName": "@griffel/webpack-loader",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}
diff --git a/packages/webpack-extraction-plugin/src/webpackLoader.ts b/packages/webpack-extraction-plugin/src/webpackLoader.ts
@@ -18,7 +18,7 @@ const virtualLoaderPath = path.resolve(__dirname, '..', 'virtual-loader', 'index
 const virtualCSSFilePath = path.resolve(__dirname, '..', 'virtual-loader', 'griffel.css');
 
 /**
- * Webpack can also pass sourcemaps as a string, Babel accepts only objects.
+ * Webpack can also pass sourcemaps as a string or null, Babel accepts only objects, boolean and undefined.
  * See https://github.com/babel/babel-loader/pull/889.
  */
 function parseSourceMap(inputSourceMap: WebpackLoaderParams[1]): TransformOptions['inputSourceMap'] {
@@ -27,6 +27,10 @@ function parseSourceMap(inputSourceMap: WebpackLoaderParams[1]): TransformOption
       return JSON.parse(inputSourceMap) as TransformOptions['inputSourceMap'];
     }
 
+    if (inputSourceMap === null) {
+      return undefined;
+    }
+
     return inputSourceMap as TransformOptions['inputSourceMap'];
   } catch (err) {
     return undefined;

diff --git a/packages/webpack-loader/src/webpackLoader.ts b/packages/webpack-loader/src/webpackLoader.ts
@@ -29,7 +29,7 @@ export function shouldTransformSourceCode(
 }
 
 /**
- * Webpack can also pass sourcemaps as a string, Babel accepts only objects.
+ * Webpack can also pass sourcemaps as a string or null, Babel accepts only objects, boolean and undefined.
  * See https://github.com/babel/babel-loader/pull/889.
  */
 function parseSourceMap(inputSourceMap: WebpackLoaderParams[1]): TransformOptions['inputSourceMap'] {
@@ -38,6 +38,10 @@ function parseSourceMap(inputSourceMap: WebpackLoaderParams[1]): TransformOption
       return JSON.parse(inputSourceMap) as TransformOptions['inputSourceMap'];
     }
 
+    if (inputSourceMap === null) {
+      return undefined;
+    }
+
     return inputSourceMap as TransformOptions['inputSourceMap'];
   } catch (err) {
     return undefined;