Merge pull request #56 from microsoft/releaseCandidate

Release candidate 1 release
microsoft · Dec 15, 2022 · 9f7695f · 9f7695f
2 parents b41c043 + 489e522
commit 9f7695f
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 4 deletions.
diff --git a/.azure-pipelines/ci-build.yml b/.azure-pipelines/ci-build.yml
@@ -260,6 +260,12 @@ stages:
             pool:
               vmImage: ubuntu-latest
             steps:
+            # Install the nuget tool.
+            - task: NuGetToolInstaller@0
+              displayName: 'Use NuGet >=5.2.0'
+              inputs:
+                versionSpec: '>=5.2.0'
+                checkLatest: true
             - task: DownloadPipelineArtifact@2
               displayName: Download nupkg from artifacts
               inputs:

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+## [1.0.0-rc.1] - 2022-12-15
+
+### Changed
+
+- Release candidate 1
+
 ## [1.0.0-preview.19] - 2022-12-13
 
 ### Changed

diff --git a/src/Microsoft.Kiota.Abstractions.csproj b/src/Microsoft.Kiota.Abstractions.csproj
@@ -14,7 +14,7 @@
     <EmbedUntrackedSources>true</EmbedUntrackedSources>
     <Deterministic>true</Deterministic>
     <VersionPrefix>1.0.0</VersionPrefix>
-    <VersionSuffix>preview.19</VersionSuffix>
+    <VersionSuffix>rc.1</VersionSuffix>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <SignAssembly>false</SignAssembly>
     <DelaySign>false</DelaySign>
@@ -23,10 +23,11 @@
     <!-- Enable this line once we go live to prevent breaking changes -->
     <!-- <PackageValidationBaselineVersion>1.0.0</PackageValidationBaselineVersion> -->
     <PackageReleaseNotes>
-        - Adds support for multi-valued headers
+        - Release candidate 1.
     </PackageReleaseNotes>
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
     <PackageLicenseFile>LICENSE</PackageLicenseFile>
+    <PackageReadmeFile>README.md</PackageReadmeFile>
   </PropertyGroup>
 
   <ItemGroup>
@@ -44,5 +45,9 @@
       <Pack>True</Pack>
       <PackagePath></PackagePath>
     </None>
+    <None Include="..\README.md">
+      <Pack>True</Pack>
+      <PackagePath></PackagePath>
+    </None>
   </ItemGroup>
 </Project>
diff --git a/src/store/InMemoryBackingStore.cs b/src/store/InMemoryBackingStore.cs
@@ -21,7 +21,7 @@ public class InMemoryBackingStore : IBackingStore
         /// </summary>
         public bool ReturnOnlyChangedValues { get; set; }
         private readonly Dictionary<string, Tuple<bool, object>> store = new();
-        private Dictionary<string, Action<string, object, object>> subscriptions = new();
+        private readonly Dictionary<string, Action<string, object, object>> subscriptions = new();
 
         /// <summary>
         /// Gets the specified object with the given key from the store.
@@ -74,7 +74,7 @@ public void Set<T>(string key, T value)
             }
             else if(value is ICollection collectionValues)
             {// if its the first time adding a IBackedModel collection property to the store, subscribe to item properties' BackingStores and use the events to flag the collection property is "dirty"
-                collectionValues.OfType<IBackedModel>().ToList().ForEach(model => model.BackingStore?.Subscribe((keyString, oldObject, newObject) => Set(key, value))); ;
+                collectionValues.OfType<IBackedModel>().ToList().ForEach(model => model.BackingStore?.Subscribe((keyString, oldObject, newObject) => Set(key, value)));
             }
 
             foreach(var sub in subscriptions.Values)