-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds IAsyncParseNodeFactory, makes deserialization methods async, upd… #225
Adds IAsyncParseNodeFactory, makes deserialization methods async, upd… #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting things started, a couple of comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes, one additional comment besides the obsolete discussion for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes, a couple of last remarks and we should be good.
Also, can you please:
- add a changelog entry (changed, patch, monday)
- bump the version (patch)
I think we should preview/validate the changes for the JSON serialization library before we merge this one in, just in case we missed something, so we can validate the design. Thoughts?
@andrueastman for final review and merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution here @MihaMarkic
Adds async deserialization capabilities