Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aligns Enum serialization across packages and pass relevant JsonWriterOptions from the KiotaJsonSerializationContext #312

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Aligns Enum serialization across packages and pass relevant JsonWriterOptions from the KiotaJsonSerializationContext #312

merged 3 commits into from
Aug 1, 2024

Conversation

andrueastman
Copy link
Member

Fixes #281
Fixes #284

This PR

  • Cleans up enum serialization to read from attributes for form and text serialization. This uses the shared helper to provide consistent results. Tests updated.
  • Pass relevant JsonWriterOptions from the KiotaJsonSerializationContext.Options to the Utf8JsonWriter when writing json to enable customization for the writer.

@andrueastman andrueastman requested a review from a team as a code owner August 1, 2024 09:57
@andrueastman andrueastman enabled auto-merge August 1, 2024 09:57
@baywet baywet disabled auto-merge August 1, 2024 11:45
@baywet baywet enabled auto-merge August 1, 2024 11:45
@andrueastman andrueastman requested a review from baywet August 1, 2024 12:07
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

baywet
baywet approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making the changes!

@baywet baywet merged commit 32c1353 into main Aug 1, 2024
9 of 11 checks passed
@baywet baywet deleted the andrueastman/fixes branch August 1, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
2 participants
@andrueastman @baywet