Added Non-Generic Solution to KiotaDeserialization #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
requested changes
Oct 11, 2024
src/abstractions/serialization/KiotaJsonSerializer.Deserialization.Untyped.cs
Outdated
Show resolved
Hide resolved
src/abstractions/serialization/KiotaJsonSerializer.Deserialization.Untyped.cs
Outdated
Show resolved
Hide resolved
|
Okay .. @baywet I was also able, to remove the |
baywet
reviewed
Oct 14, 2024
src/abstractions/serialization/KiotaJsonSerializer.Deserialization.NonGeneric.cs
Outdated
Show resolved
Hide resolved
src/abstractions/serialization/KiotaJsonSerializer.Deserialization.NonGeneric.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
…s shadowing parent methods Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
baywet
previously approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Thank you for making the changes!
I also took the liberty of making a bunch of "cleanup" changes here.
@andrueastman for final review and merge
tests/abstractions/Serialization/DeserializationHelpersTests.NonGeneric.cs
Outdated
Show resolved
Hide resolved
added 2 commits
October 28, 2024 09:47
removes duplicate tests
andrueastman
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code addition fulfills the request of Issue 210, where this was explicitly requested.
@dansmitt is a co-worker of mine and I thought, that this might be of relevance to more than just him.
I used the same Unit-Tests, as you were, modifying them just as much, to use the newly introduced method signatures.