Fix undefined behaviour in backing store #1558
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| package com.microsoft.kiota; | ||
|
|
||
| import com.microsoft.kiota.serialization.AdditionalDataHolder; | ||
| import com.microsoft.kiota.serialization.Parsable; | ||
| import com.microsoft.kiota.serialization.ParseNode; | ||
| import com.microsoft.kiota.serialization.SerializationWriter; | ||
| import com.microsoft.kiota.store.BackedModel; | ||
| import com.microsoft.kiota.store.BackingStore; | ||
| import com.microsoft.kiota.store.BackingStoreFactorySingleton; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import java.util.Objects; | ||
|
|
||
| public class BaseCollectionPaginationCountResponse | ||
| implements AdditionalDataHolder, BackedModel, Parsable { | ||
|
|
||
| /** | ||
| * Stores model information. | ||
| */ | ||
| @jakarta.annotation.Nonnull protected BackingStore backingStore; | ||
|
|
||
| /** | ||
| * Instantiates a new {@link BaseCollectionPaginationCountResponse} and sets the default values. | ||
| */ | ||
| public BaseCollectionPaginationCountResponse() { | ||
| this.backingStore = BackingStoreFactorySingleton.instance.createBackingStore(); | ||
| this.setAdditionalData(new HashMap<>()); | ||
| } | ||
|
|
||
| /** | ||
| * Creates a new instance of the appropriate class based on discriminator value | ||
| * @param parseNode The parse node to use to read the discriminator value and create the object | ||
| * @return a {@link BaseCollectionPaginationCountResponse} | ||
| */ | ||
| @jakarta.annotation.Nonnull public static BaseCollectionPaginationCountResponse createFromDiscriminatorValue( | ||
| @jakarta.annotation.Nonnull final ParseNode parseNode) { | ||
| Objects.requireNonNull(parseNode); | ||
| return new BaseCollectionPaginationCountResponse(); | ||
| } | ||
|
|
||
| /** | ||
| * Gets the AdditionalData property value. Stores additional data not described in the OpenAPI description found when deserializing. Can be used for serialization as well. | ||
| * @return a {@link Map<String, Object>} | ||
| */ | ||
| @jakarta.annotation.Nonnull public Map<String, Object> getAdditionalData() { | ||
| Map<String, Object> value = this.backingStore.get("additionalData"); | ||
| if (value == null) { | ||
| value = new HashMap<>(); | ||
| this.setAdditionalData(value); | ||
| } | ||
| return value; | ||
| } | ||
|
|
||
| /** | ||
| * Gets the backingStore property value. Stores model information. | ||
| * @return a {@link BackingStore} | ||
| */ | ||
| @jakarta.annotation.Nonnull public BackingStore getBackingStore() { | ||
| return this.backingStore; | ||
| } | ||
|
|
||
| /** | ||
| * The deserialization information for the current model | ||
| * @return a {@link Map<String, java.util.function.Consumer<ParseNode>>} | ||
| */ | ||
| @jakarta.annotation.Nonnull public Map<String, java.util.function.Consumer<ParseNode>> getFieldDeserializers() { | ||
| final HashMap<String, java.util.function.Consumer<ParseNode>> deserializerMap = | ||
| new HashMap<String, java.util.function.Consumer<ParseNode>>(2); | ||
| deserializerMap.put( | ||
| "@odata.count", | ||
| n -> { | ||
| this.setOdataCount(n.getLongValue()); | ||
| }); | ||
| deserializerMap.put( | ||
| "@odata.nextLink", | ||
| n -> { | ||
| this.setOdataNextLink(n.getStringValue()); | ||
| }); | ||
| return deserializerMap; | ||
| } | ||
|
|
||
| /** | ||
| * Gets the @odata.count property value. The OdataCount property | ||
| * @return a {@link Long} | ||
| */ | ||
| @jakarta.annotation.Nullable public Long getOdataCount() { | ||
| return this.backingStore.get("odataCount"); | ||
| } | ||
|
|
||
| /** | ||
| * Gets the @odata.nextLink property value. The OdataNextLink property | ||
| * @return a {@link String} | ||
| */ | ||
| @jakarta.annotation.Nullable public String getOdataNextLink() { | ||
| return this.backingStore.get("odataNextLink"); | ||
| } | ||
|
|
||
| /** | ||
| * Serializes information the current object | ||
| * @param writer Serialization writer to use to serialize this model | ||
| */ | ||
| public void serialize(@jakarta.annotation.Nonnull final SerializationWriter writer) { | ||
| Objects.requireNonNull(writer); | ||
| writer.writeLongValue("@odata.count", this.getOdataCount()); | ||
| writer.writeStringValue("@odata.nextLink", this.getOdataNextLink()); | ||
| writer.writeAdditionalData(this.getAdditionalData()); | ||
| } | ||
|
|
||
| /** | ||
| * Sets the AdditionalData property value. Stores additional data not described in the OpenAPI description found when deserializing. Can be used for serialization as well. | ||
| * @param value Value to set for the AdditionalData property. | ||
| */ | ||
| public void setAdditionalData(@jakarta.annotation.Nullable final Map<String, Object> value) { | ||
| this.backingStore.set("additionalData", value); | ||
| } | ||
|
|
||
| /** | ||
| * Sets the @odata.count property value. The OdataCount property | ||
| * @param value Value to set for the @odata.count property. | ||
| */ | ||
| public void setOdataCount(@jakarta.annotation.Nullable final Long value) { | ||
| this.backingStore.set("odataCount", value); | ||
| } | ||
|
|
||
| /** | ||
| * Sets the @odata.nextLink property value. The OdataNextLink property | ||
| * @param value Value to set for the @odata.nextLink property. | ||
| */ | ||
| public void setOdataNextLink(@jakarta.annotation.Nullable final String value) { | ||
| this.backingStore.set("odataNextLink", value); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for this we may need to handle the case for maps in separately as this may be an incorrect assumption for them.
Since
getObjectArrayFromCollectionWrapperwill also unwrap the values of a map as an array, the key values pairs in the map are not guaranteed to have the same type. A map i.e. additionalData can have primitives and complex backed models too..