-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 4796: Prepend global:: to references of generated C# types #4871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Can you also add an entry to the changelog please? (unreleased, changed)
Hmm, I see. Also could you share the OpenAPI documents you're using, or are those internal ones? EDIT: Alright, seems like this is unrelated as per @baywet s comment |
Yup, unrelated, its the Remove LINQ change. Regarding my OpenAPI file, its not the issue as it is. Probably its because i have a layout like this: Regarding Spain-Italy, try not to drink too much and have fun 😄 EDIT: A test to check this kind of project layout where two folders contain two kiota instalations would be awesome |
@baywet I added a changelog entry and a dedicated test for the @deinok Well, Spain would have deserved more goals. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the change
This should fix #4796 by prepending
global::
to references of generated C# types.@deinok: Can you confirm if using a kiota build of this branch to generate your clients resolves the issue? I did some tests with samples that I had at hand and it seems to work, but having confirmation from a real-world example would be nice.
cc @baywet