-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing random drops in the engine. #35
Open
sarsanaee
wants to merge
10
commits into
main
Choose a base branch
from
drop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unction. The code changes add a debug mode flag in the CMakeLists.txt file to control whether the code is built in debug mode or not. The flag is set to 0 when debug mode is off. This change improves the flexibility of the build process and allows for easier debugging when needed.
…riable * The code changes update the PmdRing class to use the machnet_testing_ member variable instead of the machnet_testing variable. This change ensures consistency and improves code readability. * The extra function deleted and machnet_testing_ variable is used direction as public member.
We have made some changes, for instance. Now we are not using compile options. Instead we use env variable and we check it specifically in the code. |
… is not thread safe. * FastRand is now a variable private to each engine instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch introduces some drops in the engine to simulate scenarios where we have drops and we want to see how reliable the stack is.
This will be enabled by a cmake option (DEBUG).