Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User/mikehillberg/readme branches #23

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

User/mikehillberg/readme branches #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4d284a
Use two branches for the two phases of PR
MikeHillberg Mar 20, 2019
0e6d9ec
Add some explanation.
MikeHillberg Mar 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,23 @@ For WinUI team members, the workflow to author specs is:

1. Ensure your proposal is approved and in plan.

2. Create a new working branch: ```/user/<username>/<feature>```
2. Create two working branches: ```user/<username>/<feature>``` and ```user/<username>/<feature>_review```.
Do your work in the first branch, save the `review` branch for later.

(Two branches allows us to do a two step PR: one a spec review within the team, local experts, and customers of the feature;
and one as a broader API review.)

3. Create a new folder for your spec under the ```active``` folder: ```/active/<feature>```

4. Author your spec using the [spec template](/spec_template.md).
Please use relative links for images or other assets in the folder.

5. When your spec is ready for review:
* Open a new pull request to merge your spec to the ```master``` branch
5. When your spec is ready for the team, area experts, and feature customers to review:
* Open a new pull request to merge your spec to the ```user/<username>/<feature>_review``` branch
* Update your proposal issue with a link to the spec PR

6. Review spec in checkpoint meetings to close open issues.
6. When your spec is complete and merged, and ready for API review,
open a PR to the ```master``` branch

7. When your spec is complete and signed off, merge the PR.

Expand Down