Skip to content

fix case sensite change issues #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: MOODLE_400_STABLE
Choose a base branch
from
Open

fix case sensite change issues #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b75ee6
fix case sensite change issues
EsdrasCaleb Jul 13, 2023
c9aafab
fix collation issues
EsdrasCaleb Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions classes/loginflow/authcode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,8 +607,8 @@ protected function handlelogin(string $oidcuniqid, array $authparams, array $tok
// Handle username change - update token, update connection.
if ($usernamechanged) {
$potentialduplicateuser = core_user::get_user_by_username($oidcusername);
if ($potentialduplicateuser) {
// Username already exists, cannot change Moodle account username, throw exception.
if ($potentialduplicateuser->id!=$tokenrec->userid) {
// Username already exists in another user, cannot change Moodle account username, throw exception.
throw new moodle_exception('erroruserwithusernamealreadyexists', 'auth_oidc', null, null, '2');
} else {
// Username does not exist:
Expand Down
2 changes: 1 addition & 1 deletion lib.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ function auth_oidc_get_tokens_with_mismatched_usernames() {
FROM {auth_oidc_token} tok
JOIN {user} u ON u.id = tok.userid
WHERE tok.userid != 0
AND u.username != tok.username';
AND u.username COLLATE utf8mb4_general_ci != tok.username COLLATE utf8mb4_general_ci';
$records = $DB->get_recordset_sql($sql);
foreach ($records as $record) {
$item = new stdClass();
Expand Down