Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support health probe #3717

Open
pongba opened this issue Jun 21, 2023 · 2 comments · May be fixed by #4868
Open

Support health probe #3717

pongba opened this issue Jun 21, 2023 · 2 comments · May be fixed by #4868
Assignees
Labels
feature request A request for new functionality Partner: Bing By or For the Bing team
Milestone

Comments

@pongba
Copy link

pongba commented Jun 21, 2023

Describe the feature you'd like supported

I would like MsQuic to have a built-in support for health probing, such that application layer can respond to the health signal and kick in mitigation steps if the underlying network stack is having trouble.

Production services usually have a need to be able to automatically mitigate situation in worst case scenario. So if MsQuic stack is having trouble in some outlier situation, application layer would want to be able to switch to kernel networking stack as a general fallback mechanism to ensure liveness.

Application layer can use certain error conditions emitted from MsQuic API for this purpose, of course. But it would be much more straightforward if there's a built-in health signaling API that simply gives a boolean signal to application layer.

Additional context

No response

@pongba pongba added the feature request A request for new functionality label Jun 21, 2023
@nibanks nibanks added this to the Future milestone Jun 28, 2023
@nibanks nibanks added the Partner: Bing By or For the Bing team label Jan 28, 2025
@nibanks nibanks moved this to Planned in DPT Iteration Tracker Jan 28, 2025
@nibanks
Copy link
Member

nibanks commented Feb 25, 2025

@pongba I'm trying to remember exactly what was needed here. Is the ask just to get a callback when the stack has entered the DoS mitigation mode internally?

@nibanks
Copy link
Member

nibanks commented Feb 25, 2025

For now, we're thinking about doing:

  1. Adding a new (optional) Listener event for DoS mitigation state.
  2. Adding a new SetParam value on the listener to opt into these events.
  3. Trigger these events for all opted in listeners in QuicLibraryEvaluateSendRetryState.

@vgmahajanshetty vgmahajanshetty moved this from Planned to In Progress in DPT Iteration Tracker Feb 26, 2025
@nibanks nibanks linked a pull request Mar 3, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A request for new functionality Partner: Bing By or For the Bing team
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants