Add New Listener Callback for DoS Mode #4868
Open
+340
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
reviewed
Feb 27, 2025
nibanks
reviewed
Feb 27, 2025
nibanks
reviewed
Feb 27, 2025
nibanks
reviewed
Feb 27, 2025
nibanks
reviewed
Feb 27, 2025
nibanks
reviewed
Feb 27, 2025
nibanks
reviewed
Feb 27, 2025
nibanks
reviewed
Feb 27, 2025
nibanks
reviewed
Feb 27, 2025
nibanks
reviewed
Feb 27, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4868 +/- ##
==========================================
- Coverage 86.27% 86.11% -0.17%
==========================================
Files 56 56
Lines 17630 17677 +47
==========================================
+ Hits 15211 15223 +12
- Misses 2419 2454 +35 ☔ View full report in Codecov by Sentry. |
nibanks
reviewed
Feb 28, 2025
nibanks
reviewed
Feb 28, 2025
nibanks
reviewed
Feb 28, 2025
nibanks
reviewed
Feb 28, 2025
nibanks
reviewed
Feb 28, 2025
nibanks
reviewed
Feb 28, 2025
nibanks
reviewed
Feb 28, 2025
nibanks
reviewed
Feb 28, 2025
nibanks
reviewed
Feb 28, 2025
nibanks
reviewed
Feb 28, 2025
nibanks
reviewed
Feb 28, 2025
nibanks
reviewed
Feb 28, 2025
nibanks
reviewed
Feb 28, 2025
nibanks
changed the title
vgmahajanshetty
commented
Mar 3, 2025
nibanks
reviewed
Mar 3, 2025
nibanks
reviewed
Mar 3, 2025
nibanks
reviewed
Mar 3, 2025
nibanks
reviewed
Mar 3, 2025
nibanks
reviewed
Mar 3, 2025
nibanks
reviewed
Mar 3, 2025
nibanks
reviewed
Mar 3, 2025
| TEST_QUIC_SUCCEEDED(ClientConfiguration.GetInitStatus()); | ||
|
|
||
| QuicAddr ServerLocalAddr(QuicAddrFamily); | ||
| MsQuicAutoAcceptListener Listener(Registration, ServerConfiguration, MsQuicConnection::NoOpCallback); |
There was a problem hiding this comment.
The listener needs to validate it actually received the expected event.
There was a problem hiding this comment.
I don't see any code handling the callback event.
nibanks
reviewed
Mar 3, 2025
nibanks
reviewed
Mar 3, 2025
Comment on lines
+833
to
+835
| MsQuicLib.HandshakeMemoryLimit = | ||
| (MsQuicLib.Settings.RetryMemoryLimit * CxPlatTotalMemory) / UINT16_MAX; | ||
| QuicLibraryEvaluateSendRetryState(); |
There was a problem hiding this comment.
Can we put this after the log below please? It might help with debugging in the future.
nibanks
reviewed
Mar 3, 2025
Comment on lines
+214
to
+215
|
|
||
|
|
nibanks
reviewed
Mar 3, 2025
Comment on lines
+1524
to
+1527
| case IOCTL_QUIC_RUN_RETRY_MEMORY_LIMIT_CONNECT: | ||
| CXPLAT_FRE_ASSERT(Params != nullptr); | ||
| QuicTestCtlRun(QuicTestRetryMemoryLimitConnect(Params->Family)); | ||
| break; |
There was a problem hiding this comment.
Suggested change
| case IOCTL_QUIC_RUN_RETRY_MEMORY_LIMIT_CONNECT: | |
| CXPLAT_FRE_ASSERT(Params != nullptr); | |
| QuicTestCtlRun(QuicTestRetryMemoryLimitConnect(Params->Family)); | |
| break; | |
| case IOCTL_QUIC_RUN_RETRY_MEMORY_LIMIT_CONNECT: | |
| CXPLAT_FRE_ASSERT(Params != nullptr); | |
| QuicTestCtlRun(QuicTestRetryMemoryLimitConnect(Params->Family)); | |
| break; |
nibanks
reviewed
Mar 3, 2025
Comment on lines
+3488
to
+3489
|
|
||
|
|
nibanks
reviewed
Mar 3, 2025
Comment on lines
+3482
to
+3487
| TEST_QUIC_SUCCEEDED( | ||
| MsQuic->SetParam( | ||
| Listener.Handle, | ||
| QUIC_PARAM_DOS_MODE_EVENTS, | ||
| sizeof(buffer), | ||
| &buffer)); |
There was a problem hiding this comment.
Suggested change
| TEST_QUIC_SUCCEEDED( | |
| MsQuic->SetParam( | |
| Listener.Handle, | |
| QUIC_PARAM_DOS_MODE_EVENTS, | |
| sizeof(buffer), | |
| &buffer)); | |
| TEST_QUIC_SUCCEEDED( | |
| MsQuic->SetParam( | |
| Listener.Handle, | |
| QUIC_PARAM_DOS_MODE_EVENTS, | |
| sizeof(buffer), | |
| &buffer)); |
nibanks
reviewed
Mar 3, 2025
Comment on lines
+3499
to
+3500
|
|
||
|
|
nibanks
reviewed
Mar 3, 2025
Comment on lines
+3465
to
+3470
| TEST_QUIC_SUCCEEDED( | ||
| MsQuic->SetParam( | ||
| NULL, | ||
| QUIC_PARAM_GLOBAL_RETRY_MEMORY_PERCENT, | ||
| sizeof(RetryMemoryLimit), | ||
| &RetryMemoryLimit)); |
There was a problem hiding this comment.
You should set this after you create the listener to trigger the event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolved #3717.
To support health probe, added new event for listeners. This event will be triggered for all opted in listeners.
Testing
Did basic tests manually.
Documentation
Is there any documentation impact for this change?