Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug builds of msquic targeting UWP. #4373

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix debug builds of msquic targeting UWP. #4373

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cafffac
Fix debug builds of msquic targeting UWP.
BillyONeal Jun 24, 2024
129bad8
Merge remote-tracking branch 'origin/main' into fix-debug-dll
BillyONeal Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,9 +598,9 @@ if(WIN32)
endif()

if (NOT QUIC_STATIC_LINK_CRT AND NOT QUIC_STATIC_LINK_PARTIAL_CRT)
# We are using dynamic linking. Ensure that only the release version of CRT is used.
message(STATUS "Configuring for release version of dynamically linked CRT")
set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreadedDLL")
# We are using dynamic linking. Ensure that only the dynamic CRT is used.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csujedihy can you please take a look here? You're the one that added this code to link only release version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that you can always just only build the release DLL for redistribution :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @csujedihy can you take a quick look at this?

message(STATUS "Configuring for dynamically linked CRT")
set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>DLL")
endif()

else() #!WIN32
Expand Down
Loading