Updated ACK_FREQUENCY according to draft-ietf-quic-ack-frequency-10

[gaurav2699]

Description

This PR updates the ACK_FREQUENCY frame to the latest draft. A new reordering threshold is added which indicates the maximum number of packets that can be out of order before an immediate acknowledgment (ACK) is triggered.

Testing

New Unit test cases have been added to test the reordering threshold logic.

Documentation

No

[codecov]

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.58%. Comparing base (9640abe) to head (a8f2386).
Report is 34 commits behind head on main.

Files with missing lines	Patch %	Lines
src/core/ack_tracker.c	84.21%	3 Missing ⚠️
src/core/connection.c	92.30%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4670      +/-   ##
==========================================
- Coverage   87.27%   86.58%   -0.70%     
==========================================
  Files          56       56              
  Lines       17361    17378      +17     
==========================================
- Hits        15152    15046     -106     
- Misses       2209     2332     +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nibanks]

Looks like CLOG needs to be updated again.

[nibanks]

QUIC_TP_ID_MIN_ACK_DELAY needs to be updated to match the latest in the spec:

min_ack_delay (0xff04de1b):
A variable-length integer representing the minimum amount of time, in microseconds, that the endpoint sending this value is willing to delay an acknowledgment. This limit could be based on the data receiver's clock or timer granularity. min_ack_delay is used by the data sender to avoid requesting too small a value in the Requested Max Ack Delay field of the ACK_FREQUENCY frame.

[nibanks]

Really close!

Copilot reviewed 2 out of 13 changed files in this pull request and generated no comments.

Files not reviewed (11)

• src/core/ack_tracker.c: Language not supported
• src/core/ack_tracker.h: Language not supported
• src/core/connection.c: Language not supported
• src/core/connection.h: Language not supported
• src/core/crypto_tls.c: Language not supported
• src/core/frame.c: Language not supported
• src/core/frame.h: Language not supported
• src/core/quicdef.h: Language not supported
• src/core/send.c: Language not supported
• src/core/unittest/FrameTest.cpp: Language not supported
• src/manifest/clog.sidecar: Language not supported

There are several test failures, especially on the Linux stress tests. Need to investigate.