Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OneBranch Build of msquictest #4688

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fix OneBranch Build of msquictest #4688

merged 1 commit into from
Dec 5, 2024

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Dec 5, 2024

Description

Fixes the following OneBranch build error of Windows user mode:

C:\__w\1\s\src\test\bin\quic_gtest.cpp(92,41): error C2065: 'QUIC_EXECUTION_CONFIG_FLAG_XDP': undeclared identifier [C:\__w\1\s\build\windows\x64_schannel\src\test\bin\msquictest.vcxproj]

This happens because internally we don't build test code with preview features enabled.

Testing

Need to run through the CI.

Documentation

N/A

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.13%. Comparing base (3c1a841) to head (ee84e84).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4688      +/-   ##
==========================================
+ Coverage   87.09%   87.13%   +0.04%     
==========================================
  Files          56       56              
  Lines       17361    17361              
==========================================
+ Hits        15120    15127       +7     
+ Misses       2241     2234       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks merged commit e53b1e0 into main Dec 5, 2024
479 of 480 checks passed
@nibanks nibanks deleted the fix-onebranch-build-test branch December 5, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants