Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run fmt and clippy for rust code #4712

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

youyuanwu
Copy link
Contributor

Description

Rust code should be formatted and linted to ensure consistency and quality.
Added fmt and clippy lint to cargo pipeline.

Testing

NA

Documentation

NA

@youyuanwu youyuanwu requested a review from a team as a code owner December 16, 2024 18:29
src/lib.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.68%. Comparing base (810b373) to head (e91ee8f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4712      +/-   ##
==========================================
- Coverage   87.17%   86.68%   -0.50%     
==========================================
  Files          56       56              
  Lines       17363    17363              
==========================================
- Hits        15137    15051      -86     
- Misses       2226     2312      +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -40,6 +40,10 @@
- name: Install Cargo
if: runner.os == 'Linux'
run: curl https://sh.rustup.rs -sSf | sh -s -- -y
- name: Cargo fmt

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 9: downloadThenRun not pinned by hash
Click Remediation section below to solve this issue
@nibanks nibanks added the Language: Rust Related to the Rust interop layer label Dec 17, 2024
src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@nibanks nibanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change!

@nibanks nibanks enabled auto-merge (squash) December 18, 2024 13:06
@nibanks nibanks merged commit 62ecc16 into microsoft:main Dec 18, 2024
481 of 484 checks passed
@youyuanwu youyuanwu deleted the users/youyuanwu/fmt-and-clippy branch December 18, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language: Rust Related to the Rust interop layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants